module: convert schema-only core module on convertCJSFilenameToURL

Co-authored-by: Joyee Cheung <[email protected]>

Author: himself65

lib/internal/modules/customization_hooks.js

@@ -130,6 +130,9 @@ function convertCJSFilenameToURL(filename) {
   if (builtinId) {
     return `node:${builtinId}`;
   }
+  if (BuiltinModule.canBeRequiredByUsers(filename)) {
+    return `node:${filename}`;
+  }
   // Handle the case where filename is neither a path, nor a built-in id,
   // which is possible via monkey-patching.
   if (isAbsolute(filename)) {

test/module-hooks/test-module-hooks-builtin-require.js

@@ -0,0 +1,44 @@
+'use strict';
+
+// This tests that when builtins that demand the `node:` prefix are
+// required, the URL that gets passed to the load hook is still
+// the one with the `node:` prefix, and the one with the prefix
+// stripped for internal lookups don't get passed into the hooks.
+
+const common = require('../common');
+const assert = require('assert');
+const { registerHooks } = require('module');
+
+const schemelessBlockList = new Set([
+  'sea',
+  'sqlite',
+  'test',
+  'test/reporters',
+]);
+
+const testModules = [];
+for (const mod of schemelessBlockList) {
+  testModules.push(`node:${mod}`);
+}
+
+const hook = registerHooks({
+  resolve: common.mustCall((specifier, context, nextResolve) => {
+    return nextResolve(specifier, context);
+  }, testModules.length),
+  load: common.mustCall(function load(url, context, nextLoad) {
+    assert.match(url, /^node:/);
+    assert.strictEqual(schemelessBlockList.has(url.slice(5, url.length)), true);
+    const result = nextLoad(url, context);
+    assert.strictEqual(result.source, null);
+    return {
+      source: 'throw new Error("I should not be thrown because the loader ignores user-supplied source for builtins")',
+      format: 'builtin',
+    };
+  }, testModules.length),
+});
+
+for (const mod of testModules) {
+  require(mod);
+}
+
+hook.deregister();