Skip to content

Commit a356f32

Browse files
RaisinTentargos
authored andcommitted
src: remove empty name check in node_env_var.cc
The empty name check has been removed since this has landed: libuv/libuv#2473 PR-URL: #36133 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent c0604c9 commit a356f32

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/node_env_var.cc

+1-3
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,7 @@ Local<Array> RealEnvStore::Enumerate(Isolate* isolate) const {
178178
for (int i = 0; i < count; i++) {
179179
#ifdef _WIN32
180180
// If the key starts with '=' it is a hidden environment variable.
181-
// The '\0' check is a workaround for the bug behind
182-
// https://github.com/libuv/libuv/pull/2473 and can be removed later.
183-
if (items[i].name[0] == '=' || items[i].name[0] == '\0') continue;
181+
if (items[i].name[0] == '=') continue;
184182
#endif
185183
MaybeLocal<String> str = String::NewFromUtf8(isolate, items[i].name);
186184
if (str.IsEmpty()) {

0 commit comments

Comments
 (0)