Skip to content

Commit d5302f5

Browse files
lemiretargos
authored andcommitted
fix: only generate embedded.cc under Windows. (#12)
1 parent 1a5726a commit d5302f5

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

tools/v8_gypfiles/v8.gyp

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -509,20 +509,22 @@
509509
'<(INTERMEDIATE_DIR)/snapshot.cc',
510510
'<(INTERMEDIATE_DIR)/embedded.cc',
511511
],
512+
'action': [
513+
'<(python)',
514+
'<(V8_ROOT)/tools/snapshot/asm_to_inline_asm.py',
515+
'<@(_inputs)',
516+
'<(INTERMEDIATE_DIR)/embedded.cc', # important: embedded.cc is only ever generated if OS == "win"
517+
],
512518
}],
513519
# Under non-Windows systems, we effectively ignore the output of this
514520
# action. We do need to build snapshot.cc, however.
515521
['OS != "win"', {
516-
'outputs': ['<(INTERMEDIATE_DIR)/snapshot.cc']
522+
'outputs': ['<(INTERMEDIATE_DIR)/snapshot.cc'],
523+
'action': [],
517524
}],
518525
],
519526
'process_outputs_as_sources': 1,
520-
'action': [
521-
'<(python)',
522-
'<(V8_ROOT)/tools/snapshot/asm_to_inline_asm.py',
523-
'<@(_inputs)',
524-
'<(INTERMEDIATE_DIR)/embedded.cc',
525-
],
527+
526528
},
527529
],
528530
}, # v8_snapshot

0 commit comments

Comments
 (0)