Skip to content

Commit da87459

Browse files
richnologiesMylesBorins
authored andcommitted
test: improve test-assert
Add RegExp to check assert throws the expected AssertionErrors. For the one with multiple flags is ok to hardcode the flags since the spec indicates the ordering will always be `gim`: Refs: http://www.ecma-international.org/ecma-262/6.0/#sec-get-regexp.prototype.flags PR-URL: #10916 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent a15ecd2 commit da87459

File tree

1 file changed

+20
-5
lines changed

1 file changed

+20
-5
lines changed

test/parallel/test-assert.js

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -216,11 +216,26 @@ assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/g, /a/g));
216216
assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/i, /a/i));
217217
assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/m, /a/m));
218218
assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/igm, /a/igm));
219-
assert.throws(makeBlock(a.deepStrictEqual, /ab/, /a/));
220-
assert.throws(makeBlock(a.deepStrictEqual, /a/g, /a/));
221-
assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/));
222-
assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/));
223-
assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im));
219+
assert.throws(
220+
makeBlock(a.deepStrictEqual, /ab/, /a/),
221+
/^AssertionError: \/ab\/ deepStrictEqual \/a\/$/
222+
);
223+
assert.throws(
224+
makeBlock(a.deepStrictEqual, /a/g, /a/),
225+
/^AssertionError: \/a\/g deepStrictEqual \/a\/$/
226+
);
227+
assert.throws(
228+
makeBlock(a.deepStrictEqual, /a/i, /a/),
229+
/^AssertionError: \/a\/i deepStrictEqual \/a\/$/
230+
);
231+
assert.throws(
232+
makeBlock(a.deepStrictEqual, /a/m, /a/),
233+
/^AssertionError: \/a\/m deepStrictEqual \/a\/$/
234+
);
235+
assert.throws(
236+
makeBlock(a.deepStrictEqual, /a/igm, /a/im),
237+
/^AssertionError: \/a\/gim deepStrictEqual \/a\/im$/
238+
);
224239

225240
{
226241
const re1 = /a/;

0 commit comments

Comments
 (0)