Skip to content

Commit e64ebac

Browse files
Trotttargos
authored andcommitted
test: fix flaky inspector-cli tests when breakpionts are restored
PR-URL: #38431 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f31a611 commit e64ebac

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

test/common/inspector-cli.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ function startCLI(args, flags = [], spawnOpts = {}) {
2323
if (this === child.stderr) {
2424
stderrOutput += chunk;
2525
}
26-
outputBuffer.push(chunk);
26+
// TODO(trott): Figure out why the "breakpoints restored." message appears
27+
// in unpredictable places especially on AIX in CI. We shouldn't be
28+
// excluding it, but it gets in the way of the output checking for tests.
29+
outputBuffer.push(chunk.replace(/\n*\d+ breakpoints restored\.\n*/mg, ''));
2730
}
2831

2932
function getOutput() {

test/inspector-cli/test-inspector-cli-pid.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,7 @@ function launchTarget(...args) {
4040
})
4141
.then(() => cli.command('sb("alive.js", 3)'))
4242
.then(() => cli.waitFor(/break/))
43-
// TODO: There is a known issue on AIX and some other operating systems
44-
// where the breakpoints aren't properly resolved yet when we reach this
45-
// point. Eventually that should be figured out but for now we don't
46-
// want to fail builds because of it.
47-
// What it should be:
48-
//
49-
// .then(() => cli.waitForPrompt())
50-
//
51-
// What we're diong for now:
52-
.then(() => cli.waitFor(/>\s+(?:\n1 breakpoints restored\.)?$/))
43+
.then(() => cli.waitForPrompt())
5344
.then(() => {
5445
assert.match(
5546
cli.output,

0 commit comments

Comments
 (0)