Skip to content

Commit eb14b10

Browse files
committed
src: remove unnecessary ToLocalChecked call
PR-URL: #36523 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent e51267b commit eb14b10

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/node_buffer.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -496,18 +496,19 @@ void StringSlice(const FunctionCallbackInfo<Value>& args) {
496496
size_t length = end - start;
497497

498498
Local<Value> error;
499-
MaybeLocal<Value> ret =
499+
MaybeLocal<Value> maybe_ret =
500500
StringBytes::Encode(isolate,
501501
buffer.data() + start,
502502
length,
503503
encoding,
504504
&error);
505-
if (ret.IsEmpty()) {
505+
Local<Value> ret;
506+
if (!maybe_ret.ToLocal(&ret)) {
506507
CHECK(!error.IsEmpty());
507508
isolate->ThrowException(error);
508509
return;
509510
}
510-
args.GetReturnValue().Set(ret.ToLocalChecked());
511+
args.GetReturnValue().Set(ret);
511512
}
512513

513514

0 commit comments

Comments
 (0)