Skip to content

Commit f55380a

Browse files
richardlautargos
authored andcommitted
deps: V8: cherry-pick f8d5e576b814
Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 PR-URL: #52183 Refs: v8/v8@c4be0a9 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> PR-URL: #51362 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
1 parent b9d806a commit f55380a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.7',
40+
'v8_embedder_string': '-node.8',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/BUILD.gn

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1696,6 +1696,10 @@ config("toolchain") {
16961696
# of `this` in capture-by-value lambdas and preventing a build roll which
16971697
# enables C++20 (see https://crbug.com/1374227).
16981698
"-Wno-deprecated",
1699+
1700+
# Fix build with older versions of GCC
1701+
# Ported from v8 bazel: https://crrev.com/c/3368869
1702+
"-Wno-stringop-overflow",
16991703
]
17001704
}
17011705

0 commit comments

Comments
 (0)