Skip to content

Commit fb73c06

Browse files
gengjiawenBethGriggs
authored andcommitted
cluster: improve for-loop
PR-URL: #26336 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e1f293c commit fb73c06

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

lib/internal/cluster/master.js

+5-9
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,7 @@ cluster.setupMaster = function(options) {
8181
if (message.cmd !== 'NODE_DEBUG_ENABLED')
8282
return;
8383

84-
var key;
85-
for (key in cluster.workers) {
86-
const worker = cluster.workers[key];
87-
84+
for (const worker of Object.values(cluster.workers)) {
8885
if (worker.state === 'online' || worker.state === 'listening') {
8986
process._debugProcess(worker.process.pid);
9087
} else {
@@ -231,11 +228,10 @@ cluster.disconnect = function(cb) {
231228
if (workers.length === 0) {
232229
process.nextTick(() => intercom.emit('disconnect'));
233230
} else {
234-
for (var key in workers) {
235-
key = workers[key];
236-
237-
if (cluster.workers[key].isConnected())
238-
cluster.workers[key].disconnect();
231+
for (const worker of Object.values(cluster.workers)) {
232+
if (worker.isConnected()) {
233+
worker.disconnect();
234+
}
239235
}
240236
}
241237

0 commit comments

Comments
 (0)