-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Closed
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.opensslIssues and PRs related to the OpenSSL dependency.Issues and PRs related to the OpenSSL dependency.
Description
A number of Node.js tests fail when Node.js is compiled dynamically linked against OpenSSL 3.2 (tested with OpenSSL 3.2.2).
i.e.
./configure --shared-openssl
make -j 4 test-ci
Full tap results: https://gist.github.com/richardlau/ce642daf2ffd581755232a924f9f8f63
Failures:
-
out/Release/node /home/nodejs/node/test/parallel/test-crypto-dh.js
test: fix OpenSSL version checks #53503 -
out/Release/node /home/nodejs/node/test/parallel/test-http2-https-fallback.js
Also fails with OpenSSL 3.0.14 test: update tests for OpenSSL 3.0.14 #53373 -
out/Release/node /home/nodejs/node/test/parallel/test-http2-server-unknown-protocol.js
Also fails with OpenSSL 3.0.14 test: update tests for OpenSSL 3.0.14 #53373 -
out/Release/node /home/nodejs/node/test/parallel/test-https-client-checkServerIdentity.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-https-strict.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-alert-handling.js
test: adjust tls test for OpenSSL32 #54909 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-cert-regression.js
test: update test to support OpenSSL32 #54968 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-client-getephemeralkeyinfo.js
test: update tls test to support OpenSSL32 #55030 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-alpn-server-client.js
Also fails with OpenSSL 3.0.14 test: update tests for OpenSSL 3.0.14 #53373 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-client-mindhsize.js
test: fix test-tls-client-mindhsize for OpenSSL32 #54739 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-client-renegotiation-13.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-client-auth.js
test: fix test-tls-client-auth test for OpenSSL32 #54610 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-client-verify.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-empty-sni-context.js
test: update TLS tests for OpenSSL 3.2 #53384 -
out/Release/node --no-warnings /home/nodejs/node/test/parallel/test-tls-dhe.js
test: fix test test-tls-dhe for OpenSSL32 #54903 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-getcipher.js
test: adjust key sizes to support OpenSSL32 #54972 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-junk-server.js
test: adjust test-tls-junk-server for OpenSSL32 #54926 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-multiple-cas-as-string.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-peer-certificate-encoding.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-multi-key.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-psk-circuit.js
test: update TLS tests for OpenSSL 3.2 #53384 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-sni-server-client.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-set-ciphers.js
test: adjust tls-set-ciphers for OpenSSL32 #55016 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-sni-option.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-server-verify.js
test: increase key size for ca2-cert.pem #54599 -
out/Release/node /home/nodejs/node/test/parallel/test-tls-junk-closes-server.js
also reported in Pass node 18.x branch tests when compiled against shared openssl 3.2 #52482 test: fix test-tls-junk-closes-server #55089 (comment)
In our Jenkins CI we currently test in node-test-commit-linux-containered Node.js dynamically linked against OpenSSL 3.0 and 3.1. Addressing the above test failures would be required before we can add testing against OpenSSL 3.2 to the CI.
adarshmadrecha
Metadata
Metadata
Assignees
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.opensslIssues and PRs related to the OpenSSL dependency.Issues and PRs related to the OpenSSL dependency.