From b620772197cad5837101e5debba8b6ade17391df Mon Sep 17 00:00:00 2001 From: Kyriakos Markakis Date: Tue, 12 Nov 2019 15:52:43 +0000 Subject: [PATCH 1/2] lib: change var to let in stream_base_commons --- lib/internal/stream_base_commons.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/internal/stream_base_commons.js b/lib/internal/stream_base_commons.js index eb2e53963d82b3..5aa371ea506e90 100644 --- a/lib/internal/stream_base_commons.js +++ b/lib/internal/stream_base_commons.js @@ -111,8 +111,8 @@ function createWriteWrap(handle) { function writevGeneric(self, data, cb) { const req = createWriteWrap(self[kHandle]); const allBuffers = data.allBuffers; - var chunks; - var i; + let chunks; + let i; if (allBuffers) { chunks = data; for (i = 0; i < data.length; i++) @@ -120,7 +120,7 @@ function writevGeneric(self, data, cb) { } else { chunks = new Array(data.length << 1); for (i = 0; i < data.length; i++) { - var entry = data[i]; + const entry = data[i]; chunks[i * 2] = entry.chunk; chunks[i * 2 + 1] = entry.encoding; } From 451c6d30f2fc7e78a96b0c38bd698f6e816ad901 Mon Sep 17 00:00:00 2001 From: Kyriakos Markakis <11089475+marquicodes@users.noreply.github.com> Date: Mon, 18 Nov 2019 20:28:16 +0100 Subject: [PATCH 2/2] lib: moved let into for loops in stream_base_commons --- lib/internal/stream_base_commons.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/internal/stream_base_commons.js b/lib/internal/stream_base_commons.js index 5aa371ea506e90..95430ff738fdb5 100644 --- a/lib/internal/stream_base_commons.js +++ b/lib/internal/stream_base_commons.js @@ -112,14 +112,13 @@ function writevGeneric(self, data, cb) { const req = createWriteWrap(self[kHandle]); const allBuffers = data.allBuffers; let chunks; - let i; if (allBuffers) { chunks = data; - for (i = 0; i < data.length; i++) + for (let i = 0; i < data.length; i++) data[i] = data[i].chunk; } else { chunks = new Array(data.length << 1); - for (i = 0; i < data.length; i++) { + for (let i = 0; i < data.length; i++) { const entry = data[i]; chunks[i * 2] = entry.chunk; chunks[i * 2 + 1] = entry.encoding;