[v22.x backport] sqlite,test,doc: allow Buffer and URL as database location #57533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#56991 Reviewed-By: Colin Ihrig <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
c++
|
This shouldn't land without the changes in #57227 |
What's the procedure? Two backports? |
|
You can push to this PR |
Cool. Will do. |
PR-URL: nodejs#57227 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>
geeksilva97
commented
Mar 18, 2025
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Mar 19, 2025
|
Hmm, that's new for me. Coverage thresholds are not being fulfilled. But it is a backport 🤔 . |
geeksilva97
added
the
author ready
We have a problem with coverage on v22.x. It's unrelated to your PR. |
RafaelGSS
approved these changes
Mar 20, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
Mar 31, 2025
PR-URL: #56991 Backport-PR-URL: #57533 Reviewed-By: Colin Ihrig <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Mar 31, 2025
PR-URL: #57227 Backport-PR-URL: #57533 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> PR-URL: #56991
|
Landed in be79f4a...2746524 |
RafaelGSS
pushed a commit
that referenced
this pull request
Mar 31, 2025
PR-URL: #56991 Backport-PR-URL: #57533 Reviewed-By: Colin Ihrig <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Mar 31, 2025
PR-URL: #57227 Backport-PR-URL: #57533 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #56991
Reviewed-By: Colin Ihrig [email protected]