Skip to content

Commit 56c7570

Browse files
authored
chore: replace eslint-config-semistandard with eslint-config-standard (#4586)
eslint-config-semistandard hasn't been published in a year as of this writing and does not install with the version of eslint that we use without --force or --legacy-peer-deps. Replace it with the up-to-date eslint-config-standard, and change the semi rule in .eslintrc to have the same impact. This also disables two (new?) rules that now flag errors in our markdown files. These can be investigated later or not. It also makes a small change to release-post.js so it complies with a rule about using object shorthand when possible. Fixes: #4585
1 parent 6c16990 commit 56c7570

File tree

4 files changed

+202
-37
lines changed

4 files changed

+202
-37
lines changed

.eslintrc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": [
33
"eslint:recommended",
4-
"semistandard",
4+
"standard",
55
"prettier"
66
],
77
"plugins": [
@@ -29,6 +29,8 @@
2929
},
3030
"rules": {
3131
"eqeqeq": "off",
32+
"n/no-deprecated-api": "off",
33+
"n/handle-callback-err": "off",
3234
"no-const-assign": "off",
3335
"no-undef": "off",
3436
"no-unused-expressions": "off",
@@ -42,7 +44,8 @@
4244
"singleQuote": true,
4345
"trailingComma": "none"
4446
}
45-
]
47+
],
48+
"semi": ["error", "always"]
4649
}
4750
}
4851
]

package-lock.json

Lines changed: 195 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"cross-env": "^7.0.3",
6161
"eslint": "^8.14.0",
6262
"eslint-config-prettier": "^8.5.0",
63-
"eslint-config-semistandard": "^16.0.0",
63+
"eslint-config-standard": "^17.0.0",
6464
"eslint-plugin-import": "^2.26.0",
6565
"eslint-plugin-markdown": "^2.2.1",
6666
"eslint-plugin-node": "^11.1.0",

scripts/release-post.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ function findAuthorLogin(version, section) {
169169

170170
function urlOrComingSoon(binary) {
171171
const url = binary.url.replace('nodejs.org', 'direct.nodejs.org');
172-
return sendRequest({ url: url, method: 'HEAD' }).then(
172+
return sendRequest({ url, method: 'HEAD' }).then(
173173
() => `${binary.title}: ${binary.url}`,
174174
() => {
175175
console.log(`\x1B[32m "${binary.title}" is Coming soon...\x1B[39m`);

0 commit comments

Comments
 (0)