From 98a53827152357950f2b39d33309f42ed185efb7 Mon Sep 17 00:00:00 2001 From: Ulises Gascon Date: Mon, 6 Feb 2023 20:04:10 +0100 Subject: [PATCH 1/3] doc: add meeting notes 2023-02-06 Signed-off-by: Ulises Gascon Co-authored-by: Yagiz Nizipli Co-authored-by: Marvin Hagemeister --- meetings/2023-02-06.md | 69 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 meetings/2023-02-06.md diff --git a/meetings/2023-02-06.md b/meetings/2023-02-06.md new file mode 100644 index 0000000..d56abc4 --- /dev/null +++ b/meetings/2023-02-06.md @@ -0,0 +1,69 @@ +# Node.js Performance Team Meeting 2023-02-06 + +## Links + +* **Recording**: https://www.youtube.com/watch?v=l8-DCAMGobE +* **GitHub Issue**: https://github.com/nodejs/performance/issues/48 + +## Present + +* Performance team: @nodejs/performance +* Yagiz Nizipli: @anonrig +* Marvin Hagemeister @marvinhagemeister +* Ulises Gascon: @ulisesGascon +* Stephen Belanger: @qard +* Santiago Gimeno: @santigimeno +* Tony Gorez: @tony-go +* Rafael Gonzaga: @RafaelGSS +* Robert Nagy: @ronag + + +## Agenda + +## Announcements + +[Ada](https://github.com/ada-url/ada), the new URL parse will be added to Node.js as dependency in order to increase speed by 78 %, fetch will become faster too 🎉 +Marvin released a really good blog post on https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-3/. + +*Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. + +### nodejs/node + +* Start time performance regression when upgrading from 16.x to 18.x [#45662](https://github.com/nodejs/node/issues/45662) +19.x changes are already merged +There is an ongoing work to port the changes to 16.x and 18.x (lead by @joyeecheung) +This item will be removed from the agenda +### nodejs/performance + +* AbortSignal is slow [#44](https://github.com/nodejs/performance/issues/44) +Reached out to RxJS folks. There are some discussions and agreements ongoing, but after checking the performance improvements there were no major upgrades +PR from Santigo (@santigimeno) improves the performance by 20% - https://github.com/nodejs/node/pull/46527 +Ongoing discussion about if this can break the spec or not +Recommendation escalate to WinterCG group +* Node errors are very slow to create [#40](https://github.com/nodejs/performance/issues/40) +This item will be removed from the agenda +* Module resolution [#39](https://github.com/nodejs/performance/issues/39) +There is an open PR relevant (pending from benchmark) +Suggestion: Implement it fully in C++. Input value is a string, return value is a boolean, so this would lend itself to use v8 fast paths +@tony-go will take a look at it +We could expose it to user land later if we found a use case for it +* fetch [#11](https://github.com/nodejs/performance/issues/11) +We move from very slow to just slow in terms of performance +There are more open opportunities, but let’s see how Ada will impact on the performance and then we can reevaluate the situation. +This item will be removed from the agenda, and the issue will be closed. We can reopen the issue if needed. +* WHATWG Streams [#9](https://github.com/nodejs/performance/issues/9) +[Last update from Rafael](https://github.com/nodejs/performance/issues/9#issuecomment-1370136019) +We will discuss it again in the next meeting +* Buffer.(read|write)(U)Int(LE|BE)(8|16|32) [#2](https://github.com/nodejs/performance/issues/2) +This item will be removed from the agenda + +* Reference to https://github.com/nodejs/performance/issues/51 + +## Q&A, Other + +## Upcoming Meetings + +* **Node.js Foundation Calendar**: https://nodejs.org/calendar + +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. + From d280c80435792ad3527663c88b58da2f312f3fe0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Mon, 6 Feb 2023 20:43:16 +0100 Subject: [PATCH 2/3] Update meetings/2023-02-06.md Co-authored-by: Santiago Gimeno --- meetings/2023-02-06.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-02-06.md b/meetings/2023-02-06.md index d56abc4..0ec07c1 100644 --- a/meetings/2023-02-06.md +++ b/meetings/2023-02-06.md @@ -38,7 +38,7 @@ This item will be removed from the agenda * AbortSignal is slow [#44](https://github.com/nodejs/performance/issues/44) Reached out to RxJS folks. There are some discussions and agreements ongoing, but after checking the performance improvements there were no major upgrades PR from Santigo (@santigimeno) improves the performance by 20% - https://github.com/nodejs/node/pull/46527 -Ongoing discussion about if this can break the spec or not +Ongoing discussion about further changes that could improve the performance even more include moving `Event.isTrusted` to the prototype and not setting `__proto__: null`. The former might break the spec. Recommendation escalate to WinterCG group * Node errors are very slow to create [#40](https://github.com/nodejs/performance/issues/40) This item will be removed from the agenda From 559de70bd5e032168c437ee282179a54628b5147 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Tue, 7 Feb 2023 07:42:39 +0100 Subject: [PATCH 3/3] Update meetings/2023-02-06.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tobias Nießen --- meetings/2023-02-06.md | 1 + 1 file changed, 1 insertion(+) diff --git a/meetings/2023-02-06.md b/meetings/2023-02-06.md index 0ec07c1..786c34c 100644 --- a/meetings/2023-02-06.md +++ b/meetings/2023-02-06.md @@ -23,6 +23,7 @@ ## Announcements [Ada](https://github.com/ada-url/ada), the new URL parse will be added to Node.js as dependency in order to increase speed by 78 %, fetch will become faster too 🎉 + Marvin released a really good blog post on https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-3/. *Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.