added new tests for errors and client (#831)

Author: KiraPC

test/client-abort.js

@@ -5,6 +5,8 @@ const { Client, errors } = require('..')
 const { createServer } = require('http')
 const { Readable } = require('stream')
 
+class OnAbortError extends Error {}
+
 test('aborted response errors', (t) => {
   t.plan(3)
 
@@ -166,3 +168,46 @@ test('abort pipelined', (t) => {
     })
   })
 })
+
+test('propagate unallowed throws in request.onError', (t) => {
+  t.plan(2)
+
+  const server = createServer((req, res) => {
+    res.end()
+  })
+  t.teardown(server.close.bind(server))
+
+  server.listen(0, () => {
+    const client = new Client(`http://localhost:${server.address().port}`)
+    t.teardown(client.destroy.bind(client))
+
+    client.dispatch({
+      method: 'GET',
+      path: '/'
+    }, {
+      onConnect (abort) {
+        setImmediate(abort)
+      },
+      onHeaders () {
+        t.pass()
+      },
+      onData () {
+        t.pass()
+      },
+      onComplete () {
+        t.pass()
+      },
+      onError () {
+        throw new OnAbortError('error')
+      }
+    })
+
+    client.on('error', (err) => {
+      t.type(err, OnAbortError)
+    })
+
+    client.on('disconnect', () => {
+      t.pass()
+    })
+  })
+})

test/errors.js

@@ -26,7 +26,8 @@ const scenarios = [
   createScenario(errors.ClientDestroyedError, 'The client is destroyed', 'ClientDestroyedError', 'UND_ERR_DESTROYED'),
   createScenario(errors.ClientClosedError, 'The client is closed', 'ClientClosedError', 'UND_ERR_CLOSED'),
   createScenario(errors.SocketError, 'Socket error', 'SocketError', 'UND_ERR_SOCKET'),
-  createScenario(errors.NotSupportedError, 'Not supported error', 'NotSupportedError', 'UND_ERR_NOT_SUPPORTED')
+  createScenario(errors.NotSupportedError, 'Not supported error', 'NotSupportedError', 'UND_ERR_NOT_SUPPORTED'),
+  createScenario(errors.ResponseContentLengthMismatchError, 'Response body length does not match content-length header', 'ResponseContentLengthMismatchError', 'UND_ERR_RES_CONTENT_LENGTH_MISMATCH')
 ]
 
 scenarios.forEach(scenario => {
@@ -65,3 +66,16 @@ scenarios.forEach(scenario => {
     t.end()
   })
 })
+
+test('Default HTTPParseError Codes', t => {
+  test('code and data should be undefined when not set', t => {
+    t.plan(2)
+
+    const error = new errors.HTTPParserError('HTTPParserError')
+
+    t.equal(error.code, undefined)
+    t.equal(error.data, undefined)
+  })
+
+  t.end()
+})