Skip to content

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Aug 19, 2025

Description

Problem*

Resolves

Summary*

This PR removes some overuse of lshift8 and optimizes lshift8 with usage of a lookup table.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Aug 19, 2025

Changes to circuit sizes

Generated at commit: f7b683c9158237ce9927bfbf71d29a70192b2ad9, compared to commit: 5fb54c8d86d83eb62279ac78b7d246f22a66b75a

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
test_sha256_200.json +242 ❌ +7.52% -351 ✅ -1.23%
test_sha256_1.json -138 ✅ -14.71% -583 ✅ -4.43%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
test_sha256_512.json 7,442 (+850) +12.89% 53,286 (+27) +0.05%
test_sha256_511.json 7,587 (+850) +12.62% 49,494 (+24) +0.05%
test_sha256_200.json 3,458 (+242) +7.52% 28,095 (-351) -1.23%
test_sha256_1.json 800 (-138) -14.71% 12,591 (-583) -4.43%

@TomAFrench TomAFrench force-pushed the tf/bitshift-changes branch from 7a76fd0 to 6bc122f Compare August 19, 2025 10:50
@TomAFrench TomAFrench marked this pull request as ready for review August 19, 2025 10:50
@jialinli98 jialinli98 self-requested a review September 3, 2025 08:22
@jialinli98 jialinli98 merged commit d398f9d into main Sep 3, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from 👀 To Triage to ✅ Done in Noir Libraries Sep 3, 2025
@github-actions github-actions bot mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants