Skip to content

refactor buffer storage 3 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 12-17-refactor_buffer_storage_split
Choose a base branch
from

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Dec 18, 2024

Important

Add wait_for_zoom_attachment() to handle race condition with zoom state in rendering process.

  • Behavior:
    • Add wait_for_zoom_attachment() in Renderer to handle race condition with zoom state.
    • Use wait_for_zoom_attachment() in ReglRenderer in regl_rendering.ts to ensure zoom state is set before rendering.
  • Types:
    • Update onZoomCallback type in types.ts to use ZoomTransform directly.
  • Imports:
    • Add Selection import from d3-selection in rendering.ts.

This description was created by Ellipsis for 01d31db. It will automatically update as commits are pushed.

Copy link
Collaborator Author

bmschmidt commented Dec 18, 2024

@bmschmidt bmschmidt marked this pull request as ready for review January 16, 2025 19:53
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 3e1b193 to 0833ce7 Compare May 23, 2025 18:29
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split_split branch from 01d31db to 75c61cc Compare May 23, 2025 18:29
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 0833ce7 to 89a8717 Compare May 23, 2025 18:37
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split_split branch from 75c61cc to bd9f1be Compare May 23, 2025 18:37
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 89a8717 to 0ae3757 Compare May 23, 2025 18:40
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split_split branch from bd9f1be to c1c0448 Compare May 23, 2025 18:40
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 0ae3757 to 61aaf34 Compare May 23, 2025 18:46
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split_split branch from c1c0448 to e631b9a Compare May 23, 2025 18:46
@bmschmidt bmschmidt marked this pull request as draft May 23, 2025 18:48
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 61aaf34 to f5d0d3a Compare May 23, 2025 19:12
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split_split branch from e631b9a to e10a35d Compare May 23, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant