-
Notifications
You must be signed in to change notification settings - Fork 69
refactor buffer storage 3 #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bmschmidt
wants to merge
2
commits into
12-17-refactor_buffer_storage_split
Choose a base branch
from
12-17-refactor_buffer_storage_split_split
base: 12-17-refactor_buffer_storage_split
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor buffer storage 3 #178
bmschmidt
wants to merge
2
commits into
12-17-refactor_buffer_storage_split
from
12-17-refactor_buffer_storage_split_split
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
Merged
Draft
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 18, 2024
Draft
bmschmidt
commented
Jan 16, 2025
3e1b193
to
0833ce7
Compare
01d31db
to
75c61cc
Compare
0833ce7
to
89a8717
Compare
75c61cc
to
bd9f1be
Compare
89a8717
to
0ae3757
Compare
bd9f1be
to
c1c0448
Compare
0ae3757
to
61aaf34
Compare
c1c0448
to
e631b9a
Compare
61aaf34
to
f5d0d3a
Compare
e631b9a
to
e10a35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
wait_for_zoom_attachment()
to handle race condition with zoom state in rendering process.wait_for_zoom_attachment()
inRenderer
to handle race condition with zoom state.wait_for_zoom_attachment()
inReglRenderer
inregl_rendering.ts
to ensure zoom state is set before rendering.onZoomCallback
type intypes.ts
to useZoomTransform
directly.Selection
import fromd3-selection
inrendering.ts
.This description was created by
for 01d31db. It will automatically update as commits are pushed.