add support for "Server" and "x-noobaa-available-storage-classes" headers

Signed-off-by: Utkarsh Srivastava <[email protected]>

make supported storage classes bucketspace specific

Signed-off-by: Utkarsh Srivastava <[email protected]>

Author: tangledbytes

src/endpoint/s3/ops/s3_head_bucket.js

@@ -1,13 +1,14 @@
 /* Copyright (C) 2016 NooBaa */
 'use strict';
 
+const s3_utils = require("../s3_utils");
+
 /**
  * http://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketHEAD.html
  */
-async function head_bucket(req) {
-    await req.object_sdk.read_bucket({ name: req.params.bucket });
-    // only called to check for existence
-    // no headers or reply needed
+async function head_bucket(req, res) {
+    const bucket_info = await req.object_sdk.read_bucket({ name: req.params.bucket });
+    s3_utils.set_response_supported_storage_classes(res, bucket_info.supported_storage_classes);
 }
 
 module.exports = {

src/endpoint/s3/s3_utils.js

@@ -36,6 +36,8 @@ const DEFAULT_OBJECT_ACL = Object.freeze({
 const XATTR_SORT_SYMBOL = Symbol('XATTR_SORT_SYMBOL');
 const base64_regex = /^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$/;
 
+const X_NOOBAA_AVAILABLE_STORAGE_CLASSES = 'x-noobaa-available-storage-classes';
+
  /**
  * get_default_object_owner returns bucket_owner info if exists
  * else it'll return the default owner
@@ -322,6 +324,18 @@ function set_response_object_md(res, object_md) {
     }
 }
 
+/**
+ * @param {nb.S3Response} res 
+ * @param {Array<string>} [supported_storage_classes]
+ */
+function set_response_supported_storage_classes(res, supported_storage_classes) {
+    if (!supported_storage_classes) {
+        supported_storage_classes = [STORAGE_CLASS_STANDARD];
+    }
+
+    res.setHeader(X_NOOBAA_AVAILABLE_STORAGE_CLASSES, supported_storage_classes);
+}
+
 /**
  * @param {nb.S3Request} req
  * @returns {nb.StorageClass}
@@ -752,4 +766,4 @@ exports.parse_restore_request_days = parse_restore_request_days;
 exports.parse_version_id = parse_version_id;
 exports.get_object_owner = get_object_owner;
 exports.get_default_object_owner = get_default_object_owner;
-
+exports.set_response_supported_storage_classes = set_response_supported_storage_classes;

src/sdk/bucketspace_fs.js

@@ -25,6 +25,7 @@ const { get_umasked_mode, isDirectory, validate_bucket_creation,
     entity_enum, translate_error_codes, update_config_file} = require('../util/native_fs_utils');
 const NoobaaEvent = require('../manage_nsfs/manage_nsfs_events_utils').NoobaaEvent;
 const { anonymous_access_key } = require('./object_sdk');
+const s3_utils = require('../endpoint/s3/s3_utils');
 
 const dbg = require('../util/debug_module')(__filename);
 const bucket_semaphore = new KeysSemaphore(1);
@@ -153,6 +154,7 @@ class BucketSpaceFS extends BucketSpaceSimpleFS {
                 id: bucket.owner_account,
                 email: bucket.bucket_owner
             };
+            bucket.supported_storage_classes = this._supported_storage_class();
             if (bucket.s3_policy) {
                 for (const [s_index, statement] of bucket.s3_policy.Statement.entries()) {
                     const statement_principal = statement.Principal || statement.NotPrincipal;
@@ -770,6 +772,22 @@ class BucketSpaceFS extends BucketSpaceSimpleFS {
     is_nsfs_non_containerized_user_anonymous(token) {
         return !token && process.env.NC_NSFS_NO_DB_ENV;
     }
+
+    /**
+     * returns a list of storage class supported by this bucketspace
+     * @returns {Array<string>}
+     */
+    _supported_storage_class() {
+        const storage_classes = [];
+        if (!config.DENY_UPLOAD_TO_STORAGE_CLASS_STANDARD) {
+            storage_classes.push(s3_utils.STORAGE_CLASS_STANDARD);
+        }
+        if (config.NSFS_GLACIER_ENABLED) {
+            storage_classes.push(s3_utils.STORAGE_CLASS_GLACIER);
+        }
+
+        return storage_classes;
+    }
 }
 
 module.exports = BucketSpaceFS;

src/util/http_utils.js

@@ -318,6 +318,8 @@ async function parse_request_body(req, options) {
 }
 
 function send_reply(req, res, reply, options) {
+    res.setHeader('Server', 'NooBaa');
+
     if (options.reply.type === 'raw') {
         // in this case the handler already replied
         dbg.log1('HTTP REPLY RAW', req.method, req.originalUrl);