NSFS | versioning | don't show .versions folder on list-object-versions

Signed-off-by: nadav mizrahi <[email protected]>

Author: nadavMiz

src/sdk/namespace_fs.js

@@ -718,8 +718,8 @@ class NamespaceFS {
                     if ((!ent.name.startsWith(prefix_ent) ||
                         ent.name < marker_curr ||
                         ent.name === this.get_bucket_tmpdir_name() ||
-                        ent.name === config.NSFS_FOLDER_OBJECT_NAME) &&
-                        !this._is_hidden_version_path(ent.name)) {
+                        ent.name === config.NSFS_FOLDER_OBJECT_NAME) ||
+                        this._is_hidden_version_path(ent.name)) {
                         return;
                     }
                     const isDir = await is_directory_or_symlink_to_directory(ent, fs_context, path.join(dir_path, ent.name));

src/test/unit_tests/test_bucketspace_versioning.js

@@ -13,6 +13,7 @@ const size_utils = require('../../util/size_utils');
 const { TMP_PATH, is_nc_coretest, set_path_permissions_and_owner, generate_nsfs_account, get_new_buckets_path_by_test_env,
     invalid_nsfs_root_permissions, generate_s3_client, get_coretest_path } = require('../system_tests/test_utils');
 const { get_process_fs_context } = require('../../util/native_fs_utils');
+const _ = require('lodash');
 
 const coretest_path = get_coretest_path();
 const coretest = require(coretest_path);
@@ -3053,6 +3054,13 @@ mocha.describe('List-objects', function() {
             }
         });
     });
+
+    mocha.it('list object versions - should not list .versions folder', async function() {
+        const res = await s3_client.listObjectVersions({Bucket: bucket_name, Delimiter: "/"});
+        res.CommonPrefixes?.forEach(obj => {
+            assert.notEqual(obj.Prefix, ".versions/");
+        });
+    });
 });
 
 async function create_object(object_path, data, version_id, return_fd) {