fix(arborist): fix file dep making wrong link (#8312)

Fixes #8302 @owlstronaut 

This was caused by
815311b

Author: alexsch01

workspaces/arborist/lib/arborist/reify.js

@@ -871,13 +871,9 @@ module.exports = cls => class Reifier extends cls {
       return relative(dir, resolve(rootDir, overridePath))
     }
 
-    // Fallback: derive the package name from node.resolved in a platform-agnostic way
+    // Fallback: derive the file path from node.resolved in a platform-agnostic way
     const filePath = node.resolved.replace(/^file:/, '')
-    // A node.package.name could be different than the folder name
-    const pathParts = filePath.split(/[\\/]/)
-    const packageName = pathParts[pathParts.length - 1]
-
-    return join('..', packageName)
+    return join(filePath)
   }
 
   #registryResolved (resolved) {

workspaces/arborist/test/arborist/reify.js

@@ -3209,7 +3209,7 @@ t.test('root overrides with file: paths are visible to workspaces', async t => {
   const path = t.testdir({
     'package.json': JSON.stringify({
       name: 'root',
-      workspaces: ['hello'],
+      workspaces: ['hello', 'nested/goodbye'],
       dependencies: {},
       overrides: {
         print: 'file:./print',
@@ -3224,6 +3224,17 @@ t.test('root overrides with file: paths are visible to workspaces', async t => {
         },
       }),
     },
+    nested: {
+      goodbye: {
+        'package.json': JSON.stringify({
+          name: 'second',
+          version: '1.0.0',
+          dependencies: {
+            print: '../print',
+          },
+        }),
+      },
+    },
     print: {
       'package.json': JSON.stringify({
         name: 'print',
@@ -3237,6 +3248,7 @@ t.test('root overrides with file: paths are visible to workspaces', async t => {
   await reify(path)
 
   const printSymlink = fs.readlinkSync(resolve(path, 'node_modules/print'))
+  const secondSymlink = fs.readlinkSync(resolve(path, 'node_modules/second'))
 
   // Create a platform-agnostic way to compare symlink targets
   const normalizeLinkTarget = target => {
@@ -3254,6 +3266,12 @@ t.test('root overrides with file: paths are visible to workspaces', async t => {
     '../print',
     'print symlink points to ../print (normalized for platform)'
   )
+
+  t.equal(
+    normalizeLinkTarget(secondSymlink),
+    '../nested/goodbye',
+    'print symlink points to ../nested/goodbye (normalized for platform)'
+  )
 })
 
 t.test('should preserve exact ranges, missing actual tree', async (t) => {