fix: make prepare and normalize have feature parity with legacy packages
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/bins-and-bin
branch
from
3b603c4 to
4248d0f
Compare
lukekarrys
changed the title
prepare have feature parity with legacy read-package-json
lukekarrys
force-pushed
the
lk/bins-and-bin
branch
from
4248d0f to
3730d67
Compare
lukekarrys
changed the title
prepare have feature parity with legacy read-package-jsonprepare and normalize have feature parity with legacy packages
lukekarrys
force-pushed
the
lk/bins-and-bin
branch
from
67f1890 to
78125c2
Compare
…ackages Due to npm/cli#6470, I added `read-package-json` and `read-package-json-fast` to this repo as dev deps to run the new tests from #31 against those packages. I found a few discrepancies which I fixed in this PR. Full list of changes are as follows: **`normalize` / `read-package-json-fast`** - convert `bundleDependencies: false` to `[]` **`prepare` / `read-package-json`** - ignore `directories.bin` if `bin` is present - walk up filesystem to look for git directory - log a warning for inaccessible bin entries but dont delete These changes will be tracked in npm/statusboard#487 to see if they should be made as breaking changes with npm 10. These legacy tests can be removed once we have decided to make these breaking changes. Ref: npm/cli#6470 Fixes: #35
lukekarrys
force-pushed
the
lk/bins-and-bin
branch
from
78125c2 to
075b90d
Compare
wraithgar
reviewed
Jun 5, 2023
wraithgar
reviewed
Jun 6, 2023
lukekarrys
force-pushed
the
lk/bins-and-bin
branch
from
88751c2 to
1ea9b52
Compare
wraithgar
reviewed
Jun 6, 2023
| } catch { | ||
| delete data.bin[key] | ||
| log.warn('package-json', pkgId, `No bin file found at ${data.bin[key]}`) | ||
| // XXX: should a future breaking change delete bin entries that cannot be accessed? |
Member
There was a problem hiding this comment.
No, if anything we should throw and refuse to accept it.
wraithgar
approved these changes
Jun 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to npm/cli#6470, I added
read-package-jsonandread-package-json-fastto this repo as dev deps to run the new tests from #31 against those packages. I found a few discrepancies which I fixed in this PR.Full list of changes are as follows:
normalize/read-package-json-fastbundleDependencies: falseto[]prepare/read-package-jsondirectories.binifbinis presentThese changes will be tracked in npm/statusboard#487 to see if they should be made as breaking changes with npm 10.
These legacy tests can be removed once we have decided to make these breaking changes.
Ref: npm/cli#6470
Fixes: #35