Skip to content

Commit c0c95bf

Browse files
lukekarryslukekarrys
committed
fix: do not collapse chores for now
1 parent 8ff563d commit c0c95bf

9 files changed

+387
-661
lines changed

‎lib/release/changelog.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ class Changelog {
3131
#getEntries (type) {
3232
const section = this.#sections[type]
3333
const entries = this.#entries[type].map(list)
34+
// Ignoring coverage until we use this again
35+
/* istanbul ignore next */
3436
if (section?.collapse) {
3537
entries.unshift('<details><summary>Commits</summary>\n')
3638
entries.push('\n</details>')

‎tap-snapshots/test/release/release-please-cases-chore-commit.js.test.cjs

Lines changed: 19 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,15 @@ Object {
1313
---
1414
1515
16-
<details><summary>2016.0.2-pre</summary>
16+
<details><summary>2017.0.3-pre</summary>
1717
18-
## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
18+
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)
1919
2020
### Chores
2121
2222
<details><summary>Commits</summary>
2323
24-
* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
25-
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
24+
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)
2625
2726
</details>
2827
</details>
@@ -35,40 +34,39 @@ Object {
3534
"labels": Array [
3635
"autorelease: pending",
3736
],
38-
"number": 264,
39-
"sha": "675ff2fa3a03500ce5748e38d05c003d80943e43",
40-
"title": "chore: release 2016.0.2-pre",
37+
"number": 268,
38+
"sha": "9e96e7aa386e69fd38783b037402d2ffd64fb5fc",
39+
"title": "chore: release 2017.0.3-pre",
4140
}
4241
`
4342

4443
exports[`test/release/release-please.js TAP cases chore commit > releases chore commit 1`] = `
4544
Array [
4645
Object {
4746
"draft": false,
48-
"id": 132552731,
49-
"major": 2016,
47+
"id": 132694534,
48+
"major": 2017,
5049
"minor": 0,
51-
"name": "v2016.0.2-pre",
50+
"name": "v2017.0.3-pre",
5251
"notes": String(
53-
## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
52+
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)
5453
5554
### Chores
5655
5756
Commits
5857
59-
* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
60-
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
58+
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)
6159
),
62-
"patch": 2,
60+
"patch": 3,
6361
"path": ".",
6462
"pkgName": "npm-cli-release-please",
65-
"prNumber": 264,
66-
"publishTag": "prerelease-2016",
67-
"sha": "eaa230680541215efd72568054f187e8cebdd2a5",
68-
"tagName": "v2016.0.2-pre",
69-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552731/assets{?name,label}",
70-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2016.0.2-pre",
71-
"version": "2016.0.2-pre",
63+
"prNumber": 268,
64+
"publishTag": "prerelease-2017",
65+
"sha": "13b89ef2a76c624b3ebccda40ee817c4112744fc",
66+
"tagName": "v2017.0.3-pre",
67+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694534/assets{?name,label}",
68+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2017.0.3-pre",
69+
"version": "2017.0.3-pre",
7270
},
7371
]
7472
`

‎tap-snapshots/test/release/release-please-cases-fix-all.js.test.cjs

Lines changed: 169 additions & 329 deletions
Large diffs are not rendered by default.

‎tap-snapshots/test/release/release-please-cases-fix-one.js.test.cjs

Lines changed: 71 additions & 121 deletions
Original file line numberDiff line numberDiff line change
@@ -13,71 +13,45 @@ Object {
1313
---
1414
1515
16-
<details><summary>2016.0.1-pre</summary>
16+
<details><summary>2017.0.2-pre</summary>
1717
18-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
18+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.1-pre...v2017.0.2-pre) (2023-12-05)
1919
2020
### Bug Fixes
2121
22-
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
22+
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
2323
2424
### Dependencies
2525
26-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`[email protected]\`
27-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`[email protected]\`
28-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
29-
30-
### Bug Fixes
31-
32-
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
33-
34-
### Dependencies
35-
36-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`[email protected]\`
37-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`[email protected]\`
38-
39-
### Chores
40-
41-
<details><summary>Commits</summary>
42-
43-
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
44-
45-
</details>
46-
47-
### Chores
48-
49-
<details><summary>Commits</summary>
50-
51-
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
52-
53-
</details>
26+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2017.0.2-pre): \`[email protected]\`
27+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`[email protected]\`
5428
</details>
5529
56-
<details><summary>pkg1: 2016.0.1-pre</summary>
30+
<details><summary>pkg1: 2017.0.2-pre</summary>
5731
58-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2016.0.0-pre...pkg1-v2016.0.1-pre) (2023-12-04)
32+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2017.0.1-pre...pkg1-v2017.0.2-pre) (2023-12-05)
5933
6034
### Dependencies
6135
62-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
36+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`pkg2@2017.0.2-pre\`
6337
</details>
6438
65-
<details><summary>pkg2: 2016.0.1-pre</summary>
39+
<details><summary>pkg2: 2017.0.2-pre</summary>
6640
67-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2016.0.0-pre...pkg2-v2016.0.1-pre) (2023-12-04)
41+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2017.0.1-pre...pkg2-v2017.0.2-pre) (2023-12-05)
6842
6943
### Dependencies
7044
71-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2016.0.1-pre): \`@npmcli/pkg3@2016.0.1-pre\`
45+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2017.0.2-pre): \`@npmcli/pkg3@2017.0.2-pre\`
7246
</details>
7347
74-
<details><summary>pkg3: 2016.0.1-pre</summary>
48+
<details><summary>pkg3: 2017.0.2-pre</summary>
7549
76-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2016.0.0-pre...pkg3-v2016.0.1-pre) (2023-12-04)
50+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2017.0.1-pre...pkg3-v2017.0.2-pre) (2023-12-05)
7751
7852
### Bug Fixes
7953
80-
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
54+
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
8155
</details>
8256
8357
---
@@ -88,138 +62,114 @@ Object {
8862
"labels": Array [
8963
"autorelease: pending",
9064
],
91-
"number": 263,
92-
"sha": "bd4c9b0771b575fc993a70bdfda26392c5aebf3a",
93-
"title": "chore: release 2016.0.1-pre",
65+
"number": 267,
66+
"sha": "b3ff3a8d68d6bab0d83fd82ba0bd260ebe296bb8",
67+
"title": "chore: release 2017.0.2-pre",
9468
}
9569
`
9670

9771
exports[`test/release/release-please.js TAP cases fix one > releases fix one 1`] = `
9872
Array [
9973
Object {
10074
"draft": false,
101-
"id": 132552599,
102-
"major": 2016,
75+
"id": 132694353,
76+
"major": 2017,
10377
"minor": 0,
104-
"name": "v2016.0.1-pre",
78+
"name": "v2017.0.2-pre",
10579
"notes": String(
106-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
107-
108-
### Bug Fixes
109-
110-
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
111-
112-
### Dependencies
113-
114-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`[email protected]\`
115-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`[email protected]\`
116-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
80+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.1-pre...v2017.0.2-pre) (2023-12-05)
11781
11882
### Bug Fixes
11983
120-
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
84+
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
12185
12286
### Dependencies
12387
124-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`[email protected]\`
125-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`[email protected]\`
126-
127-
### Chores
128-
129-
Commits
130-
131-
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
132-
133-
134-
135-
### Chores
136-
137-
Commits
138-
139-
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
88+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2017.0.2-pre): \`[email protected]\`
89+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`[email protected]\`
14090
),
141-
"patch": 1,
91+
"patch": 2,
14292
"path": ".",
14393
"pkgName": "npm-cli-release-please",
144-
"prNumber": 263,
145-
"publishTag": "prerelease-2016",
146-
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
147-
"tagName": "v2016.0.1-pre",
148-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552599/assets{?name,label}",
149-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2016.0.1-pre",
150-
"version": "2016.0.1-pre",
94+
"prNumber": 267,
95+
"publishTag": "prerelease-2017",
96+
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
97+
"tagName": "v2017.0.2-pre",
98+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694353/assets{?name,label}",
99+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2017.0.2-pre",
100+
"version": "2017.0.2-pre",
151101
},
152102
Object {
153103
"draft": false,
154-
"id": 132552602,
155-
"major": 2016,
104+
"id": 132694359,
105+
"major": 2017,
156106
"minor": 0,
157-
"name": "pkg1: v2016.0.1-pre",
107+
"name": "pkg1: v2017.0.2-pre",
158108
"notes": String(
159-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2016.0.0-pre...pkg1-v2016.0.1-pre) (2023-12-04)
109+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2017.0.1-pre...pkg1-v2017.0.2-pre) (2023-12-05)
160110
161111
### Dependencies
162112
163-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
113+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`pkg2@2017.0.2-pre\`
164114
),
165-
"patch": 1,
115+
"patch": 2,
166116
"path": "pkg1",
167117
"pkgName": "pkg1",
168-
"prNumber": 263,
169-
"publishTag": "prerelease-2016",
170-
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
171-
"tagName": "pkg1-v2016.0.1-pre",
172-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552602/assets{?name,label}",
173-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre",
174-
"version": "2016.0.1-pre",
118+
"prNumber": 267,
119+
"publishTag": "prerelease-2017",
120+
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
121+
"tagName": "pkg1-v2017.0.2-pre",
122+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694359/assets{?name,label}",
123+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2017.0.2-pre",
124+
"version": "2017.0.2-pre",
175125
},
176126
Object {
177127
"draft": false,
178-
"id": 132552604,
179-
"major": 2016,
128+
"id": 132694369,
129+
"major": 2017,
180130
"minor": 0,
181-
"name": "pkg2: v2016.0.1-pre",
131+
"name": "pkg2: v2017.0.2-pre",
182132
"notes": String(
183-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2016.0.0-pre...pkg2-v2016.0.1-pre) (2023-12-04)
133+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2017.0.1-pre...pkg2-v2017.0.2-pre) (2023-12-05)
184134
185135
### Dependencies
186136
187-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2016.0.1-pre): \`@npmcli/pkg3@2016.0.1-pre\`
137+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2017.0.2-pre): \`@npmcli/pkg3@2017.0.2-pre\`
188138
),
189-
"patch": 1,
139+
"patch": 2,
190140
"path": "pkg2",
191141
"pkgName": "pkg2",
192-
"prNumber": 263,
193-
"publishTag": "prerelease-2016",
194-
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
195-
"tagName": "pkg2-v2016.0.1-pre",
196-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552604/assets{?name,label}",
197-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre",
198-
"version": "2016.0.1-pre",
142+
"prNumber": 267,
143+
"publishTag": "prerelease-2017",
144+
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
145+
"tagName": "pkg2-v2017.0.2-pre",
146+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694369/assets{?name,label}",
147+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre",
148+
"version": "2017.0.2-pre",
199149
},
200150
Object {
201151
"draft": false,
202-
"id": 132552609,
203-
"major": 2016,
152+
"id": 132694374,
153+
"major": 2017,
204154
"minor": 0,
205-
"name": "pkg3: v2016.0.1-pre",
155+
"name": "pkg3: v2017.0.2-pre",
206156
"notes": String(
207-
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2016.0.0-pre...pkg3-v2016.0.1-pre) (2023-12-04)
157+
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2017.0.1-pre...pkg3-v2017.0.2-pre) (2023-12-05)
208158
209159
### Bug Fixes
210160
211-
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
161+
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
212162
),
213-
"patch": 1,
163+
"patch": 2,
214164
"path": "pkg3",
215165
"pkgName": "@npmcli/pkg3",
216-
"prNumber": 263,
217-
"publishTag": "prerelease-2016",
218-
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
219-
"tagName": "pkg3-v2016.0.1-pre",
220-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552609/assets{?name,label}",
221-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2016.0.1-pre",
222-
"version": "2016.0.1-pre",
166+
"prNumber": 267,
167+
"publishTag": "prerelease-2017",
168+
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
169+
"tagName": "pkg3-v2017.0.2-pre",
170+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694374/assets{?name,label}",
171+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2017.0.2-pre",
172+
"version": "2017.0.2-pre",
223173
},
224174
]
225175
`

0 commit comments

Comments
 (0)