Skip to content

Does not support FIPS compliance and actually breaks NPM #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayohrling opened this issue Nov 13, 2015 · 2 comments
Closed

Does not support FIPS compliance and actually breaks NPM #6

ayohrling opened this issue Nov 13, 2015 · 2 comments

Comments

@ayohrling
Copy link

When NodeJS is compiled for FIPS-compliance, write-file-atomic actually breaks NPM.

When NPM attempts to write the local cache file .cache.json using writeFile from the library, it throws the following:

fips_md.c(146): OpenSSL internal error, assertion failed: Digest update previous FIPS forbidden algorithm error ignored
Aborted

Instead of hardcoding md5 hash for the temporary name, consider moving to something higher like sha1 at a minimum or check for FIPs compliance and make it variable. I tested by moving the function createhash() call to sha1 and it proceeds fine.

@stefanmb
Copy link

@ayohrling Should be resolved in #7.

@othiym23
Copy link
Contributor

othiym23 commented Dec 4, 2015

This is fixed by 22dd875, which was landed in lieu of #7 because of my poor reading comprehension skills (sorry again, @stefanmb). [email protected] (currently npm@next) includes the fixed version of write-file-atomic, and should work with FIPS builds of Node.js. Thanks for the heads up!

@othiym23 othiym23 closed this as completed Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants