feat: use reactive config for providers

Author: 9romise

src/index.ts

@@ -5,8 +5,8 @@ import {
   PNPM_WORKSPACE_PATTERN,
   VERSION_TRIGGER_CHARACTERS,
 } from '#constants'
-import { defineExtension } from 'reactive-vscode'
-import { languages } from 'vscode'
+import { defineExtension, watchEffect } from 'reactive-vscode'
+import { Disposable, languages } from 'vscode'
 import { PackageJsonExtractor } from './extractors/package-json'
 import { PnpmWorkspaceYamlExtractor } from './extractors/pnpm-workspace-yaml'
 import { displayName, version } from './generated-meta'
@@ -15,14 +15,17 @@ import { registerDiagnosticCollection } from './providers/diagnostics'
 import { NpmxHoverProvider } from './providers/hover/npmx'
 import { config, logger } from './state'
 
-export const { activate, deactivate } = defineExtension((ctx) => {
+export const { activate, deactivate } = defineExtension(() => {
   logger.info(`${displayName} Activated, v${version}`)
 
   const packageJsonExtractor = new PackageJsonExtractor()
   const pnpmWorkspaceYamlExtractor = new PnpmWorkspaceYamlExtractor()
 
-  if (config.hover.enabled) {
-    ctx.subscriptions.push(
+  watchEffect((onCleanup) => {
+    if (!config.hover.enabled)
+      return
+
+    const disposables = [
       languages.registerHoverProvider(
         { pattern: PACKAGE_JSON_PATTERN },
         new NpmxHoverProvider(packageJsonExtractor),
@@ -31,11 +34,16 @@ export const { activate, deactivate } = defineExtension((ctx) => {
         { pattern: PNPM_WORKSPACE_PATTERN },
         new NpmxHoverProvider(pnpmWorkspaceYamlExtractor),
       ),
-    )
-  }
+    ]
+
+    onCleanup(() => Disposable.from(...disposables).dispose())
+  })
 
-  if (config.completion.version !== 'off') {
-    ctx.subscriptions.push(
+  watchEffect((onCleanup) => {
+    if (config.completion.version === 'off')
+      return
+
+    const disposables = [
       languages.registerCompletionItemProvider(
         { pattern: PACKAGE_JSON_PATTERN },
         new VersionCompletionItemProvider(packageJsonExtractor),
@@ -46,8 +54,10 @@ export const { activate, deactivate } = defineExtension((ctx) => {
         new VersionCompletionItemProvider(pnpmWorkspaceYamlExtractor),
         ...VERSION_TRIGGER_CHARACTERS,
       ),
-    )
-  }
+    ]
+
+    onCleanup(() => Disposable.from(...disposables).dispose())
+  })
 
   registerDiagnosticCollection({
     [PACKAGE_JSON_BASENAME]: packageJsonExtractor,

src/providers/diagnostics/index.ts

@@ -5,7 +5,7 @@ import type { Diagnostic, TextDocument } from 'vscode'
 import { basename } from 'node:path'
 import { config, logger } from '#state'
 import { getPackageInfo } from '#utils/api/package'
-import { useActiveTextEditor, useDocumentText, watch } from 'reactive-vscode'
+import { computed, useActiveTextEditor, useDocumentText, watch } from 'reactive-vscode'
 import { languages } from 'vscode'
 import { displayName } from '../../generated-meta'
 import { checkDeprecation } from './rules/deprecation'
@@ -17,7 +17,7 @@ export interface NodeDiagnosticInfo extends Pick<Diagnostic, 'message' | 'severi
 }
 export type DiagnosticRule = (dep: DependencyInfo, pkg: ResolvedPackument) => Awaitable<NodeDiagnosticInfo | undefined>
 
-function getEnabledRules(): DiagnosticRule[] {
+const enabledRules = computed<DiagnosticRule[]>(() => {
   const rules: DiagnosticRule[] = []
   if (config.diagnostics.deprecation)
     rules.push(checkDeprecation)
@@ -26,7 +26,7 @@ function getEnabledRules(): DiagnosticRule[] {
   if (config.diagnostics.vulnerability)
     rules.push(checkVulnerability)
   return rules
-}
+})
 
 export function registerDiagnosticCollection(mapping: Record<string, Extractor | undefined>) {
   const diagnosticCollection = languages.createDiagnosticCollection(displayName)
@@ -49,7 +49,7 @@ export function registerDiagnosticCollection(mapping: Record<string, Extractor |
         try {
           const pkg = await getPackageInfo(dep.name)
 
-          for (const rule of getEnabledRules()) {
+          for (const rule of enabledRules.value) {
             const diagnostic = await rule(dep, pkg)
 
             if (diagnostic) {