fix: Don't mark "waiting for orher Expectation" as an error

Because expectations with errors are prioritized down, we should only mark them if there was really an issue with them

Author: nytamin

shared/packages/api/src/worker.ts

@@ -21,6 +21,7 @@ export type ReturnTypeIsExpectationReadyToStartWorkingOn =
 	| {
 			ready: false
 			sourceExists?: boolean
+			isWaitingForAnother?: boolean
 			reason: Reason
 	  }
 export type ReturnTypeIsExpectationFullfilled =

shared/packages/expectationManager/src/expectationManager.ts

@@ -1036,7 +1036,7 @@ export class ExpectationManager {
 									state: ExpectedPackageStatusAPI.WorkStatusState.NEW,
 									reason: readyToStart.reason,
 									status: newStatus,
-									isError: true,
+									isError: !readyToStart.isWaitingForAnother,
 								})
 							}
 						}
@@ -1579,6 +1579,7 @@ export class ExpectationManager {
 					user: `Waiting for "${waitingFor.exp.statusReport.label}"`,
 					tech: `Waiting for "${waitingFor.exp.statusReport.label}"`,
 				},
+				isWaitingForAnother: true,
 			}
 		}