fix: ensure that target file paths exists before writing to file

Author: nytamin

shared/packages/worker/src/worker/accessorHandlers/fileShare.ts

@@ -29,6 +29,8 @@ import { FileShareAccessorHandleType, GenericFileAccessorHandle } from './lib/Fi
 import { MonitorInProgress } from '../lib/monitorInProgress'
 import { MAX_EXEC_BUFFER } from '../lib/lib'
 import { defaultCheckHandleRead, defaultCheckHandleWrite } from './lib/lib'
+import * as path from 'path'
+import { mkdirp } from 'mkdirp'
 
 const fsStat = promisify(fs.stat)
 const fsAccess = promisify(fs.access)
@@ -250,6 +252,8 @@ export class FileShareAccessorHandle<Metadata> extends GenericFileAccessorHandle
 
 		const fullPath = this.workOptions.useTemporaryFilePath ? this.temporaryFilePath : this.fullPath
 
+		await mkdirp(path.dirname(fullPath)) // Create folder if it doesn't exist
+
 		// Remove the file if it exists:
 		let exists = false
 		try {

shared/packages/worker/src/worker/accessorHandlers/localFolder.ts

@@ -26,6 +26,7 @@ import { GenericFileAccessorHandle, LocalFolderAccessorHandleType } from './lib/
 import { MonitorInProgress } from '../lib/monitorInProgress'
 import { compareResourceIds } from '../workers/windowsWorker/lib/lib'
 import { defaultCheckHandleRead, defaultCheckHandleWrite } from './lib/lib'
+import { mkdirp } from 'mkdirp'
 
 const fsStat = promisify(fs.stat)
 const fsAccess = promisify(fs.access)
@@ -199,6 +200,8 @@ export class LocalFolderAccessorHandle<Metadata> extends GenericFileAccessorHand
 
 		const fullPath = this.workOptions.useTemporaryFilePath ? this.temporaryFilePath : this.fullPath
 
+		await mkdirp(path.dirname(fullPath)) // Create folder if it doesn't exist
+
 		// Remove the file if it exists:
 		let exists = false
 		try {

tests/internal-tests/src/__tests__/basic.spec.ts

@@ -69,7 +69,7 @@ describe('Basic', () => {
 					sources: [getLocalSource('source0', 'file0Source.mp4')],
 				},
 				endRequirement: {
-					targets: [getLocalTarget('target0', 'file0Target.mp4')],
+					targets: [getLocalTarget('target0', 'myFolder/file0Target.mp4')],
 					content: {
 						filePath: 'file0Target.mp4',
 					},
@@ -90,14 +90,13 @@ describe('Basic', () => {
 
 		expect(env.expectationStatuses['copy0'].statusInfo.status).toEqual('fulfilled')
 
-		expect(await fsStat('/targets/target0/file0Target.mp4')).toMatchObject({
+		expect(await fsStat('/targets/target0/myFolder/file0Target.mp4')).toMatchObject({
 			size: 1234,
 		})
 	})
 	test('Be able to copy Networked file to local', async () => {
 		fs.__mockSetFile('\\\\networkShare/sources/source1/file0Source.mp4', 1234)
 		fs.__mockSetDirectory('/targets/target1')
-		// console.log(fs.__printAllFiles())
 
 		env.expectationManager.updateExpectations({
 			copy0: literal<Expectation.FileCopy>({