feat: enforce a default delay removal package

Author: jstarpl

apps/package-manager/packages/generic/src/configManifest.ts

@@ -1,6 +1,9 @@
 import { DeviceConfigManifest, ConfigManifestEntryType } from '@sofie-automation/server-core-integration'
 import { LogLevel } from '@sofie-package-manager/api'
 
+export const DEFAULT_DELAY_REMOVAL_PACKAGE = 21600000
+export const DEFAULT_DELAY_REMOVAL_PACKAGE_INFO = 21600000
+
 export const PACKAGE_MANAGER_DEVICE_CONFIG: DeviceConfigManifest = {
 	deviceConfig: [
 		{
@@ -14,11 +17,13 @@ export const PACKAGE_MANAGER_DEVICE_CONFIG: DeviceConfigManifest = {
 			id: 'delayRemoval',
 			name: 'Delay removal of packages (milliseconds)',
 			type: ConfigManifestEntryType.INT,
+			defaultVal: DEFAULT_DELAY_REMOVAL_PACKAGE,
 		},
 		{
 			id: 'delayRemovalPackageInfo',
 			name: 'Delay removal of package scan results (milliseconds)',
 			type: ConfigManifestEntryType.INT,
+			defaultVal: DEFAULT_DELAY_REMOVAL_PACKAGE_INFO,
 		},
 		{
 			id: 'useTemporaryFilePath',

apps/package-manager/packages/generic/src/coreHandler.ts

@@ -31,7 +31,11 @@ import {
 	setLogLevel,
 	getLogLevel,
 } from '@sofie-package-manager/api'
-import { PACKAGE_MANAGER_DEVICE_CONFIG } from './configManifest'
+import {
+	DEFAULT_DELAY_REMOVAL_PACKAGE,
+	DEFAULT_DELAY_REMOVAL_PACKAGE_INFO,
+	PACKAGE_MANAGER_DEVICE_CONFIG,
+} from './configManifest'
 import { PackageManagerHandler } from './packageManager'
 
 export interface CoreConfig {
@@ -253,10 +257,11 @@ export class CoreHandler {
 			}
 
 			if (this.deviceSettings['delayRemoval'] !== this.delayRemoval) {
-				this.delayRemoval = this.deviceSettings['delayRemoval']
+				this.delayRemoval = Number(this.deviceSettings['delayRemoval']) || DEFAULT_DELAY_REMOVAL_PACKAGE
 			}
 			if (this.deviceSettings['delayRemovalPackageInfo'] !== this.delayRemovalPackageInfo) {
-				this.delayRemovalPackageInfo = this.deviceSettings['delayRemovalPackageInfo']
+				this.delayRemovalPackageInfo =
+					Number(this.deviceSettings['delayRemovalPackageInfo']) || DEFAULT_DELAY_REMOVAL_PACKAGE_INFO
 			}
 			if (this.deviceSettings['useTemporaryFilePath'] !== this.useTemporaryFilePath) {
 				this.useTemporaryFilePath = this.deviceSettings['useTemporaryFilePath']