Skip to content

Commit c6dfe14

Browse files
committed
chore(repo): skip react-router typecheck e2e test due to vite version conflict (#35110)
## Current Behavior The react-router typecheck e2e test fails in CI because pnpm resolves both vite 7 and vite 8 in the generated project. `@react-router/dev` picks up vite 8 plugin types while `defineConfig` uses vite 7 types, causing a TypeScript incompatibility. ## Expected Behavior The test is skipped until `@react-router/dev` adds Vite 8 support, at which point the `useViteV7` workaround and this skip can both be removed. ## Related Issue(s) Follow-up to #35101 (cherry picked from commit 6962a3d)
1 parent 5771eb3 commit c6dfe14

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

e2e/react/src/react-router-ts-solution.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ describe('React Router Applications - TS Solution', () => {
3737
checkFilesExist(`${appName}/vite.config.mts`);
3838
});
3939

40-
it('should be able to build, lint, test and typecheck a react-router application', async () => {
40+
// TODO: re-enable once @react-router/dev supports Vite 8 — currently pnpm can resolve both vite 7 and 8, causing typecheck failures
41+
xit('should be able to build, lint, test and typecheck a react-router application', async () => {
4142
const buildResult = runCLI(`build ${appName}`);
4243
const lintResult = runCLI(`lint ${appName}`);
4344
const testResult = runCLI(`test ${appName}`);

0 commit comments

Comments
 (0)