Skip to content

feat(angular): generate pipes with a - type separator #31243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

leosvelperez
Copy link
Member

  • Update pipe and scam pipe generators to use a - type separator by default for Angular v20
  • Generate pipes with a . type separator for Angular versions below v20
  • Add the typeSeparator option to allow choosing between both

Note: a migration will be provided in a separate PR so existing workspaces continue generating pipes with the . type separator.

@leosvelperez leosvelperez requested a review from Coly010 May 16, 2025 09:05
@leosvelperez leosvelperez self-assigned this May 16, 2025
@leosvelperez leosvelperez requested review from a team as code owners May 16, 2025 09:05
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 16, 2025 10:09am

Copy link
Contributor

nx-cloud bot commented May 16, 2025

View your CI Pipeline Execution ↗ for commit 9a0587e.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 26m 6s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 2m 39s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 10:32:49 UTC

@leosvelperez leosvelperez force-pushed the angular/v20-pipe-type-separator branch from 053c875 to 9a0587e Compare May 16, 2025 09:58
@leosvelperez leosvelperez merged commit ae417aa into angular/v20 May 16, 2025
6 checks passed
@leosvelperez leosvelperez deleted the angular/v20-pipe-type-separator branch May 16, 2025 11:21
leosvelperez added a commit that referenced this pull request May 19, 2025
- Update pipe and scam pipe generators to use a `-` type separator by
default for Angular v20
- Generate pipes with a `.` type separator for Angular versions below
v20
- Add the `typeSeparator` option to allow choosing between both

Note: a migration will be provided in a separate PR so existing
workspaces continue generating pipes with the `.` type separator.
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant