Intermittent Failure in TcpServerTests

[CharliePoole]

I've observed a recent failure in the test MultipleClientConnections() which connects 3 clients to the server and verifies that they all connected.

In the context of some other failures we have noted, this one could be very helpful since it is such a limited test:
making the connection and nothing more. Unfortunately, I have not yet been able to make it fail locally.

[CharliePoole]

It turns out that the test was not testing what it should. The connections were being done synchronously rather than asynchronously. The only failure was in not recording the last connection in rare cases.

I've revised the tests so that they now fail routinely. In this case, a good thing. :-)

I'll be creating a WIP PR in order to get more eyes on this. I first want to be sure that the test itself has no faults. Once that's sure, we can get on to fixing the bug.

[CharliePoole]

This issue has been resolved in version 4.0.0-beta.2

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org