Skip to content

Improvements to PackageSettings and SettingDefinitions APIs #1774

@CharliePoole

Description

@CharliePoole

These new API classes were introduced to make package settings type-aware. They are lacking a few features...

  1. Because we support both known settings, defined in SettingDefinitions and unknown settings of Type string, int or bool, it's possible for a user to add a known setting with an incorrect Type. The methods of PackageSettings that permit this are Add(string name, string value), Add(string, name, bool value) and Add(string name, int value). These should give an error if a known setting name is used with an incorrect Type.
  2. To support item 1, SettingDefinitions needs a static lookup method to provide the SettingDefinition associated with a name.
  3. PackageSettings needs methods to remove a setting when required.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions