Add --enable and --disable for extensions and fix --teamcity#1627
Merged
Conversation
stevenaw
approved these changes
Feb 27, 2025
Member
There was a problem hiding this comment.
Thanks @CharliePoole No concerns from me.
Curious to hear your thoughts on if we should be issuing a warning or info of some kind if a user tries to "disable" an extension which couldn't be found. There would be no functional difference to the run either way, of course, but such a scenario could arise from a misconfiguration that a user may appreciate a notice about.
Member
Author
|
Thanks for reviewing @stevenaw . I thought about a warning and didn't do it for several reasons.
So, I decided to leave it out on the principle that someone with a use case where a warning would really be helpful can always ask for a change. |
Member
|
That makes a lot of sense. Thanks for the explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1570