Exclude some not run tests from console report#1722
Merged
Conversation
Member
Author
|
See description of the change in the issue #431 |
veleek
reviewed
Jul 3, 2025
| string? label = resultNode.GetAttribute("label"); | ||
| switch (label) | ||
| { | ||
| case "Explicit": |
Member
There was a problem hiding this comment.
Should these attribute values all be case sensitive, or is it worth doing a case insensitive check?
Member
Author
There was a problem hiding this comment.
I remember asking myself the same question as I coded this. What I think is that they are exact here, because we create them exactly. Both the names and the values are case sensitive. They are also exact when used as attributes in the test code. We may allow (I can't remember) case-insensitive values at the command-line, which isn't relevant here.
I think the bottom line is whether we want to accept XML input from non-nunit sources, which might not be completely correct from our point of view. I'd say no to that.
veleek
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431