-
-
Notifications
You must be signed in to change notification settings - Fork 696
Can specify a port of the dev ws #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Although I'm not so familiar with the current implementation, here are some information for you. Goal: Add option(s) to have a control on Nuxt Content's WebSocket server First, you need to change interface of the module options. Lines 38 to 161 in 8cab297
When you add new options, it's better to check type definition of unjs/listhen's Second, you need to define the default value(s) for the options. Lines 181 to 197 in 8cab297
Third, as you described, change the call of Line 419 in 8cab297
You may need to add a unit test in https://github.com/nuxt/content/tree/main/test By the way, since Nuxt Content v2 have already reached to stable version, design of option schema should be well-designed for it not to be legacy (generally, no breaking change are supposed to be made while its major version is same). You could start to develop a PR for demonstration, or might want to get feedback from the authors and other people in the community about design before creating a PR. I will post another message if I come up with an idea. |
Is your feature request related to a problem? Please describe
The
4000
port is used by Nuxt Content v2 when I start a Nuxt dev server which can be already in use or require a port forwarding (both in my case).There is no hint anywhere that Nuxt Content need a port to work.
Describe the solution you'd like
Can specify a port number in the
content
Nuxt config object.Describe alternatives you've considered
For now I shutdown my other project which use
4000
and map the port4000
of the docker container running the Nuxt dev server.Additional context
https://github.com/nuxt/content/blob/main/src/module.ts#L419
I am not so sure what this imply but I guess I can try work on this to do a PR to add a
port
inModuleOptions
with a default to4000
to specify the port for Listhen.Tell me what kind of change will be relevant, I can try to implement something.
The text was updated successfully, but these errors were encountered: