Skip to content

Commit 150b334

Browse files
committed
fix(Modal/Slideover): don't emit close:prevent on closeAutoFocus
1 parent bf56e15 commit 150b334

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

src/runtime/components/Modal.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,15 +104,15 @@ const contentEvents = computed(() => {
104104
}
105105
106106
if (!props.dismissible) {
107-
const events = ['pointerDownOutside', 'interactOutside', 'escapeKeyDown', 'closeAutoFocus'] as const
108-
type EventType = typeof events[number]
107+
const events = ['pointerDownOutside', 'interactOutside', 'escapeKeyDown']
108+
109109
return events.reduce((acc, curr) => {
110110
acc[curr] = (e: Event) => {
111111
e.preventDefault()
112112
emits('close:prevent')
113113
}
114114
return acc
115-
}, {} as Record<EventType, (e: Event) => void>)
115+
}, defaultEvents as Record<typeof events[number] | keyof typeof defaultEvents, (e: Event) => void>)
116116
}
117117
118118
return defaultEvents

src/runtime/components/Popover.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@ const portalProps = usePortal(toRef(() => props.portal))
7575
const contentProps = toRef(() => defu(props.content, { side: 'bottom', sideOffset: 8, collisionPadding: 8 }) as PopoverContentProps)
7676
const contentEvents = computed(() => {
7777
if (!props.dismissible) {
78-
const events = ['pointerDownOutside', 'interactOutside', 'escapeKeyDown'] as const
79-
type EventType = typeof events[number]
78+
const events = ['pointerDownOutside', 'interactOutside', 'escapeKeyDown']
79+
8080
return events.reduce((acc, curr) => {
8181
acc[curr] = (e: Event) => {
8282
e.preventDefault()
8383
emits('close:prevent')
8484
}
8585
return acc
86-
}, {} as Record<EventType, (e: Event) => void>)
86+
}, {} as Record<typeof events[number], (e: Event) => void>)
8787
}
8888
8989
return {}

src/runtime/components/Slideover.vue

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,17 @@ const contentEvents = computed(() => {
103103
const defaultEvents = {
104104
closeAutoFocus: (e: Event) => e.preventDefault()
105105
}
106+
106107
if (!props.dismissible) {
107-
const events = ['pointerDownOutside', 'interactOutside', 'escapeKeyDown', 'closeAutoFocus'] as const
108-
type EventType = typeof events[number]
108+
const events = ['pointerDownOutside', 'interactOutside', 'escapeKeyDown']
109+
109110
return events.reduce((acc, curr) => {
110111
acc[curr] = (e: Event) => {
111112
e.preventDefault()
112113
emits('close:prevent')
113114
}
114115
return acc
115-
}, {} as Record<EventType, (e: Event) => void>)
116+
}, defaultEvents as Record<typeof events[number] | keyof typeof defaultEvents, (e: Event) => void>)
116117
}
117118
118119
return defaultEvents

0 commit comments

Comments
 (0)