Skip to content

Commit f54fc4f

Browse files
committed
[Perf] Improve performance of listing aliases
Fixes #3054
1 parent edacf82 commit f54fc4f

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

nvm.sh

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1068,7 +1068,7 @@ nvm_list_aliases() {
10681068

10691069
(
10701070
local ALIAS_NAME
1071-
for ALIAS_NAME in "$(nvm_node_prefix)" "stable" "unstable"; do
1071+
for ALIAS_NAME in "$(nvm_node_prefix)" "stable" "unstable" "$(nvm_iojs_prefix)"; do
10721072
{
10731073
# shellcheck disable=SC2030,SC2031 # (https://github.com/koalaman/shellcheck/issues/2217)
10741074
if [ ! -f "${NVM_ALIAS_DIR}/${ALIAS_NAME}" ] && { [ -z "${ALIAS}" ] || [ "${ALIAS_NAME}" = "${ALIAS}" ]; }; then
@@ -1077,11 +1077,6 @@ nvm_list_aliases() {
10771077
} &
10781078
done
10791079
wait
1080-
ALIAS_NAME="$(nvm_iojs_prefix)"
1081-
# shellcheck disable=SC2030,SC2031 # (https://github.com/koalaman/shellcheck/issues/2217)
1082-
if [ ! -f "${NVM_ALIAS_DIR}/${ALIAS_NAME}" ] && { [ -z "${ALIAS}" ] || [ "${ALIAS_NAME}" = "${ALIAS}" ]; }; then
1083-
NVM_NO_COLORS="${NVM_NO_COLORS-}" NVM_CURRENT="${NVM_CURRENT}" nvm_print_default_alias "${ALIAS_NAME}"
1084-
fi
10851080
) | sort
10861081

10871082
(
@@ -1376,9 +1371,10 @@ nvm_ls() {
13761371

13771372
if [ "${NVM_ADD_SYSTEM-}" = true ]; then
13781373
if [ -z "${PATTERN}" ] || [ "${PATTERN}" = 'v' ]; then
1379-
VERSIONS="${VERSIONS}$(command printf '\n%s' 'system')"
1374+
VERSIONS="${VERSIONS}
1375+
system"
13801376
elif [ "${PATTERN}" = 'system' ]; then
1381-
VERSIONS="$(command printf '%s' 'system')"
1377+
VERSIONS="system"
13821378
fi
13831379
fi
13841380

0 commit comments

Comments
 (0)