Skip to content

Commit 6d3bc38

Browse files
Merge pull request #350 from objectbox/chore/dart-sdk-2_15
Fix CI for Dart SDK 2.15
2 parents 3c34e8c + 8434f6b commit 6d3bc38

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/dart.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ jobs:
4141
- ubuntu-20.04
4242
sdk:
4343
- stable
44+
- 2.14.0
45+
- 2.13.0
4446
- 2.12.0 # currently the lowest fully supported version (i.e. generator + lib)
4547
runs-on: ${{ matrix.os }}
4648
steps:

objectbox/tool/valgrind.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
. "$(dirname "$0")"/common.sh
22

3-
# Note: when you see the process seemingly stuck after printing "All tests passed!", it's because dart2native produced
4-
# binaries will wait for any background isolates to finish before stopping the process.
3+
# Note: when you see the process seemingly stuck after printing "All tests passed!", it's because `dart compile exe`
4+
# produced binaries will wait for any background isolates to finish before stopping the process.
55
# For example, the following code has the issue: `HttpClient().get(...)`
66
# while `final httpClient = HttpClient(); httpClient.get(...); httpClient.close(force: true);` works fine.
77

@@ -19,7 +19,7 @@ mkdir -pv "${testDir}"
1919
function testWithValgrind() {
2020
echo "Running $1 with valgrind"
2121
testExe="${testDir}/${1%.*}"
22-
dart2native "${root}/test/${1}" --output "${testExe}" --verbose
22+
dart compile exe "${root}/test/${1}" --output "${testExe}" --verbose
2323
valgrind \
2424
--leak-check=full \
2525
--error-exitcode=1 \

0 commit comments

Comments
 (0)