Merge pull request #3895 from maxonfjvipon/bug/#3300/more-strict-objects-retrival

bug(#3300): refactored `PhPackage`

Author: yegor256

eo-runtime/pom.xml

@@ -235,7 +235,6 @@ SOFTWARE.
             <goals>
               <goal>register</goal>
               <goal>compile</goal>
-              <goal>lint</goal>
               <goal>transpile</goal>
               <goal>xmir-to-phi</goal>
               <goal>phi-to-xmir</goal>
@@ -244,11 +243,6 @@ SOFTWARE.
               <goal>unspile</goal>
             </goals>
             <configuration>
-              <removeBinaries>
-                <glob>EOorg/EOeolang/EOhamcrest/**</glob>
-                <glob>EOorg/EOeolang/EOmath/**</glob>
-                <glob>EOorg/EOeolang/EOfs/**</glob>
-              </removeBinaries>
               <withRuntimeDependency>false</withRuntimeDependency>
               <placeBinariesThatHaveSources>true</placeBinariesThatHaveSources>
             </configuration>

eo-runtime/src/main/eo/org/eolang/bytes.eo

@@ -27,8 +27,6 @@
 +rt jvm org.eolang:eo-runtime:0.0.0
 +rt node eo2js-runtime:0.0.0
 +version 0.0.0
-+unlint object-has-data
-+unlint broken-alias-second
 
 # The object encapsulates a chain of bytes, adding a few
 # convenient operations to it. Objects like `int`, `string`,
@@ -37,27 +35,55 @@
   data > @
   $ > as-bytes
   eq 01- > as-bool
-
   # Turn this chain of eight bytes into a number.
   # If there are less or more than eight bytes, there will
   # be an error returned.
-  [] > as-number
-    if. > @
-      eq nan.as-bytes
-      nan
+  if. > as-number
+    eq nan.as-bytes
+    nan
+    if.
+      eq positive-infinity.as-bytes
+      positive-infinity
       if.
-        eq positive-infinity.as-bytes
-        positive-infinity
+        eq negative-infinity.as-bytes
+        negative-infinity
         if.
-          eq negative-infinity.as-bytes
-          negative-infinity
-          if.
-            size.eq 8
-            number ^
-            error
-              sprintf
-                "Can't convert non 8 length bytes to a number, bytes are %x"
-                * ^
+          size.eq 8
+          number $
+          error
+            sprintf
+              "Can't convert non 8 length bytes to a number, bytes are %x"
+              * $
+  # Turn this chain of eight bytes into a i64 number.
+  # If there are less or more than eight bytes, there will
+  # be an error returned.
+  if. > as-i64
+    size.eq 8
+    i64 $
+    error
+      sprintf
+        "Can't convert non 8 length bytes to i64, bytes are %x"
+        * $
+  # Turn this chain of four bytes into a i32 number.
+  # If there are less or more than four bytes, there will
+  # be an error returned.
+  if. > as-i32
+    size.eq 4
+    i32 $
+    error
+      sprintf
+        "Can't convert non 4 length bytes to i32, bytes are %x"
+        * $
+  # Turn this chain of two bytes into a i16 number.
+  # If there are less or more than two bytes, there will
+  # be an error returned.
+  if. > as-i16
+    size.eq 2
+    i16 $
+    error
+      sprintf
+        "Can't convert non 2 length bytes to i16, bytes are %x"
+        * $
 
   # Equals to another object.
   # A condition where two objects have the same value or content.
@@ -70,42 +96,6 @@
   # Represents a sub-sequence inside the current one.
   [start len] > slice /org.eolang.bytes
 
-  # Turn this chain of eight bytes into a i64 number.
-  # If there are less or more than eight bytes, there will
-  # be an error returned.
-  [] > as-i64
-    if. > @
-      size.eq 8
-      i64 ^
-      error
-        sprintf
-          "Can't convert non 8 length bytes to i64, bytes are %x"
-          * ^
-
-  # Turn this chain of four bytes into a i32 number.
-  # If there are less or more than four bytes, there will
-  # be an error returned.
-  [] > as-i32
-    if. > @
-      size.eq 4
-      i32 ^
-      error
-        sprintf
-          "Can't convert non 4 length bytes to i32, bytes are %x"
-          * ^
-
-  # Turn this chain of two bytes into a i16 number.
-  # If there are less or more than two bytes, there will
-  # be an error returned.
-  [] > as-i16
-    if. > @
-      size.eq 2
-      i16 ^
-      error
-        sprintf
-          "Can't convert non 2 length bytes to i16, bytes are %x"
-          * ^
-
   # Calculate the bitwise and operation.
   [b] > and /org.eolang.bytes
 

eo-runtime/src/main/eo/org/eolang/cti.eo

@@ -24,7 +24,6 @@
 +home https://github.com/objectionary/eo
 +package org.eolang
 +version 0.0.0
-+unlint object-has-data
 
 # Compile Time Instruction (CTI).
 #

eo-runtime/src/main/eo/org/eolang/dataized.eo

@@ -24,7 +24,6 @@
 +home https://github.com/objectionary/eo
 +package org.eolang
 +version 0.0.0
-+unlint object-has-data
 
 # The object dataizes `target`, makes new instance of `bytes` from given data and behaves as result
 # `bytes`.

eo-runtime/src/main/eo/org/eolang/error.eo

@@ -26,7 +26,7 @@
 +rt jvm org.eolang:eo-runtime:0.0.0
 +rt node eo2js-runtime:0.0.0
 +version 0.0.0
-+unlint object-has-data
++unlint unit-test-missing
 
 # This object must be used in order to terminate the program
 # due to an error. Just make a copy of it with any encapsulated object.

eo-runtime/src/main/eo/org/eolang/false.eo

@@ -24,7 +24,7 @@
 +home https://github.com/objectionary/eo
 +package org.eolang
 +version 0.0.0
-+unlint object-has-data
++unlint unit-test-missing
 
 # The object is a FALSE boolean state.
 [] > false

eo-runtime/src/main/eo/org/eolang/fs/dir.eo

@@ -27,8 +27,6 @@
 +rt jvm org.eolang:eo-runtime:0.0.0
 +rt node eo2js-runtime:0.0.0
 +version 0.0.0
-+unlint object-has-data
-+unlint broken-alias-second
 
 # Directory in the file system.
 # Apparently every directory is a file.

eo-runtime/src/main/eo/org/eolang/fs/file.eo

@@ -27,9 +27,6 @@
 +rt jvm org.eolang:eo-runtime:0.0.0
 +rt node eo2js-runtime:0.0.0
 +version 0.0.0
-+unlint object-has-data
-+unlint broken-ref
-+unlint broken-alias-second
 
 # The file object in the filesystem.
 [path] > file

eo-runtime/src/main/eo/org/eolang/fs/path.eo

@@ -30,10 +30,6 @@
 +home https://github.com/objectionary/eo
 +package org.eolang.fs
 +version 0.0.0
-+unlint object-has-data
-+unlint broken-ref
-+unlint broken-alias-second
-+unlint unused-alias
 
 # A `path` represents a path that is hierarchical and composed of a sequence of
 # directory and file name elements separated by a special separator or delimiter.
@@ -45,6 +41,13 @@
         string uri.as-bytes
       posix
         string uri.as-bytes
+  # The system-dependent default name-separator character.
+  # On UNIX systems the value of this field is "/";
+  # on Microsoft Windows systems it is "\\".
+  if. > separator
+    os.is-windows
+    win32.separator
+    posix.separator
 
   # Utility object that joins given `tuple` of paths with current OS separator
   # and normalizes result path.
@@ -60,29 +63,18 @@
         win32 joined-path
         posix joined-path
 
-  # The system-dependent default name-separator character.
-  # On UNIX systems the value of this field is "/";
-  # on Microsoft Windows systems it is "\\".
-  [] > separator
-    if. > @
-      os.is-windows
-      win32.separator
-      posix.separator
-
   # POSIX specified path.
   # A standardized way to represent file or directory locations in a Unix-like system.
   [uri] > posix
     $ > determined
     "/" > separator
     (file uri).as-file > as-file
     (dir (QQ.fs.file uri)).as-dir > as-dir
-    uri > @
-
     # Returns `true` if current path is absolute - starts with '/' char.
-    [] > is-absolute
-      and. > @
-        uri.length.gt 0
-        (uri.as-bytes.slice 0 1).eq separator
+    and. > is-absolute
+      uri.length.gt 0
+      (uri.as-bytes.slice 0 1).eq separator
+    uri > @
 
     # Return new `path` with normalized uri.
     # Normalization includes:

eo-runtime/src/main/eo/org/eolang/fs/tmpdir.eo

@@ -28,10 +28,6 @@
 +home https://github.com/objectionary/eo
 +package org.eolang.fs
 +version 0.0.0
-+unlint object-has-data
-+unlint broken-ref
-+unlint broken-alias-second
-+unlint unused-alias
 
 # Temporary directory.
 # For Unix/MacOS uses the path supplied by the first environment variable