Skip to content

Commit b0ef701

Browse files
authored
Merge pull request #4153 from h1alexbel/4148
bug(#4148): `lints` up to 0.0.48
2 parents 27e64a0 + b195b0d commit b0ef701

31 files changed

Lines changed: 60 additions & 28 deletions

eo-maven-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<dependency>
2424
<groupId>org.eolang</groupId>
2525
<artifactId>lints</artifactId>
26-
<version>0.0.47</version>
26+
<version>0.0.48</version>
2727
</dependency>
2828
<dependency>
2929
<groupId>org.glassfish</groupId>

eo-maven-plugin/src/main/java/org/eolang/maven/MjLint.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ private int lintAll(final ConcurrentHashMap<Severity, Integer> counts) throws IO
181181
.filter(defect -> this.skipExperimentalLints || !defect.experimental())
182182
.forEach(
183183
defect -> {
184-
final Node node = pkg.get(defect.program()).inner();
184+
final Node node = pkg.get(defect.object()).inner();
185185
new Xembler(
186186
MjLint.embedded(
187187
new Directives().xpath("/object").addIf("errors").strict(1),
@@ -246,7 +246,7 @@ private XML linted(
246246
*/
247247
private static void logOne(final Defect defect) {
248248
final StringBuilder message = new StringBuilder()
249-
.append(defect.program())
249+
.append(defect.object())
250250
.append(':').append(defect.line())
251251
.append(' ')
252252
.append(defect.text())

eo-runtime/pom.xml

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,20 @@
227227
<ignoreRuntime>true</ignoreRuntime>
228228
<lintAsPackage>false</lintAsPackage>
229229
<skipSourceLints>
230-
<lint>empty-object</lint>
230+
<!--
231+
@todo #4148:35min Enable `unused-void-attr` lint.
232+
We should enable this lint after the following issue with magic
233+
voids will be resolved: https://github.com/objectionary/lints/issues/574.
234+
Don't forget to enable `unused-void-attr` in the `test–compile` execution as well.
235+
-->
231236
<lint>unused-void-attr</lint>
237+
<!--
238+
@todo #4148:35min Enable `duplicate-names-in-diff-context` lint.
239+
For now its too pedantic. See this: https://github.com/objectionary/lints/issues/578.
240+
Also, we should fix the bug with false positives with lambda object names in the atoms,
241+
in order to enable this lint.
242+
-->
243+
<lint>duplicate-names-in-diff-context</lint>
232244
</skipSourceLints>
233245
<keepBinaries>
234246
<glob>EOorg/package-info.class</glob>
@@ -261,11 +273,20 @@
261273
<generatedDir>${project.build.directory}/generated-test-sources</generatedDir>
262274
<ignoreRuntime>true</ignoreRuntime>
263275
<skipSourceLints>
264-
<lint>unit-test-without-phi</lint>
265276
<lint>unused-void-attr</lint>
277+
<!--
278+
@todo #4148:35min Enable `anonymous-formation` lint after required fixes.
279+
We should enable `anonymous-formation` lint, right after these issues will resolved in
280+
linter: https://github.com/objectionary/lints/issues/561, https://github.com/objectionary/lints/issues/562.
281+
-->
266282
<lint>anonymous-formation</lint>
267283
</skipSourceLints>
268284
<skipProgramLints>
285+
<!--
286+
@todo #4148:35min Enable `inconsistent-args` lint after its adjustment.
287+
We should enable this lint after the issue with self object names will be resolved:
288+
https://github.com/objectionary/lints/issues/576.
289+
-->
269290
<lint>inconsistent-args</lint>
270291
</skipProgramLints>
271292
</configuration>

eo-runtime/src/main/eo/org/eolang/io/dead-output.eo

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
+version 0.0.0
55
+spdx SPDX-FileCopyrightText Copyright (c) 2016-2025 Objectionary.com
66
+spdx SPDX-License-Identifier: MIT
7-
+unlint no-attribute-formation:11
8-
+unlint no-attribute-formation:21
97

108
# Dead output is an output that writes to nowhere.
119
[] > dead-output

eo-runtime/src/main/eo/org/eolang/math/random.eo

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
+version 0.0.0
88
+spdx SPDX-FileCopyrightText Copyright (c) 2016-2025 Objectionary.com
99
+spdx SPDX-License-Identifier: MIT
10-
+unlint no-attribute-formation:39
1110

1211
# Generates a pseudo-random number.
1312
[seed] > random

eo-runtime/src/main/eo/org/eolang/math/real.eo

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
+version 0.0.0
88
+spdx SPDX-FileCopyrightText Copyright (c) 2016-2025 Objectionary.com
99
+spdx SPDX-License-Identifier: MIT
10-
+unlint no-attribute-formation:32
11-
+unlint no-attribute-formation:42
1210

1311
# Returns a floating point number.
1412
[num] > real

eo-runtime/src/main/eo/org/eolang/txt/text.eo

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@
99
+version 0.0.0
1010
+spdx SPDX-FileCopyrightText Copyright (c) 2016-2025 Objectionary.com
1111
+spdx SPDX-License-Identifier: MIT
12-
+unlint no-attribute-formation:44
13-
+unlint no-attribute-formation:69
14-
+unlint no-attribute-formation:268
15-
+unlint no-attribute-formation:304
16-
+unlint no-attribute-formation:382
1712

1813
# Text.
1914
# A sequence of characters representing words, sentences, or data.

eo-runtime/src/test/eo/org/eolang/bytes-tests.eo

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
+version 0.0.0
66
+spdx SPDX-FileCopyrightText Copyright (c) 2016-2025 Objectionary.com
77
+spdx SPDX-License-Identifier: MIT
8+
+unlint duplicate-names-in-diff-context
89

910
# This unit test is supposed to check the functionality of the corresponding object.
1011
[] > bytes-tests

eo-runtime/src/test/eo/org/eolang/dataized-tests.eo

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
+version 0.0.0
66
+spdx SPDX-FileCopyrightText Copyright (c) 2016-2025 Objectionary.com
77
+spdx SPDX-License-Identifier: MIT
8+
+unlint duplicate-names-in-diff-context
89

910
# This unit test is supposed to check the functionality of the corresponding object.
1011
[] > dataized-tests

eo-runtime/src/test/eo/org/eolang/fs/dir-tests.eo

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
+version 0.0.0
88
+spdx SPDX-FileCopyrightText Copyright (c) 2016-2025 Objectionary.com
99
+spdx SPDX-License-Identifier: MIT
10+
+unlint duplicate-names-in-diff-context
1011

1112
# This unit test is supposed to check the functionality of the corresponding object.
1213
[] > dir-tests

0 commit comments

Comments
 (0)