Refactor object name stripping logic for better readability

Author: yegor256

eo-maven-plugin/src/main/java/org/eolang/maven/ObjectsIndex.java

@@ -71,13 +71,20 @@ final class ObjectsIndex {
      * @throws Exception If something unexpected happened.
      */
     public boolean contains(final String name) throws Exception {
-        return this.objects.value().contains(name);
+        final String prefix = "org.eolang.";
+        final String stripped;
+        if (name.startsWith(prefix)) {
+            stripped = name.substring(prefix.length());
+        } else {
+            stripped = name;
+        }
+        return this.objects.value().contains(stripped);
     }
 
     /**
      * Converts object name to the format that is used in the objectionary.
-     * - "objects/org/eolang/array.eo" -> "org.eolang.array"
-     * - "tests/org/eolang/seq-tests.eo" -> "org.eolang.seq-tests"
+     * - "objects/array.eo" -> "array"
+     * - "objects/io/stdout.eo" -> "io.stdout"
      * @param name Object name in raw format.
      * @return Object name in objectionary format.
      */

eo-maven-plugin/src/main/java/org/eolang/maven/OyRemote.java

@@ -172,11 +172,18 @@ static final class UrlOy {
          * @throws MalformedURLException in case of incorrect URL
          */
         public URL value(final String name) throws MalformedURLException {
+            final String prefix = "org.eolang.";
+            final String stripped;
+            if (name.startsWith(prefix)) {
+                stripped = name.substring(prefix.length());
+            } else {
+                stripped = name;
+            }
             return new URL(
                 String.format(
                     this.template,
                     this.hash.value(),
-                    name.replace(".", "/")
+                    stripped.replace(".", "/")
                 )
             );
         }

eo-maven-plugin/src/test/java/org/eolang/maven/ObjectsIndexTest.java

@@ -21,40 +21,39 @@
 final class ObjectsIndexTest {
 
     @Test
-    @SuppressWarnings("PMD.UnnecessaryLocalRule")
     void runsContainsWithOnlyOneCallToDecoratedObject() throws Exception {
         final AtomicInteger calls = new AtomicInteger(0);
-        final String object = "org.eolang.io.stderr";
         final ObjectsIndex index = new ObjectsIndex(
             new ScalarOf<>(
                 () -> {
                     calls.incrementAndGet();
-                    return Collections.singleton(object);
+                    return Collections.singleton("io.stderr");
                 }
             )
         );
-        index.contains(object);
-        index.contains(object);
+        index.contains("org.eolang.io.stderr");
+        index.contains("org.eolang.io.stderr");
         MatcherAssert.assertThat(
-            "The number of calls should be 1",
+            String.format(
+                "Scalar was called %d times instead of exactly once",
+                calls.get()
+            ),
             calls.get(),
             Matchers.is(1)
         );
     }
 
     @Test
-    @SuppressWarnings("PMD.UnnecessaryLocalRule")
     void runsContainsSuccessfully() throws Exception {
-        final String object = "org.eolang.io.stderr";
         MatcherAssert.assertThat(
             "The object must contain the value",
             new ObjectsIndex(
                 new ScalarOf<>(
                     () -> {
-                        return Collections.singleton(object);
+                        return Collections.singleton("io.stderr");
                     }
                 )
-            ).contains(object),
+            ).contains("org.eolang.io.stderr"),
             Matchers.is(true)
         );
     }
@@ -66,7 +65,7 @@ void doesNotContainUnknownValue() throws Exception {
             new ObjectsIndex(
                 new ScalarOf<>(
                     () -> {
-                        return Collections.singleton("org.eolang.io.stderr");
+                        return Collections.singleton("io.stderr");
                     }
                 )
             ).contains("unknown"),

eo-maven-plugin/src/test/java/org/eolang/maven/OyIndexedTest.java

@@ -47,7 +47,7 @@ void containsInFakeIndex() throws IOException {
             "OyIndexed with fake index must contain stdout object, but it doesn't",
             new OyIndexed(
                 new Objectionary.Fake(),
-                new ObjectsIndex(() -> Collections.singleton(this.stdout()))
+                new ObjectsIndex(() -> Collections.singleton("io.stdout"))
             ).contains(this.stdout()),
             Matchers.is(true)
         );

eo-maven-plugin/src/test/java/org/eolang/maven/OyRemoteTest.java

@@ -28,9 +28,9 @@ void buildsCorrectUrlForProgram() throws Exception {
             new OyRemote.UrlOy(
                 "https://raw/objectionary/home/%s/objects/%s.eo",
                 "abcde"
-            ).value("org.eolang.app"),
+            ).value("org.eolang.io.stdout"),
             Matchers.is(
-                new URL("https://raw/objectionary/home/abcde/objects/org/eolang/app.eo")
+                new URL("https://raw/objectionary/home/abcde/objects/io/stdout.eo")
             )
         );
     }
@@ -42,9 +42,9 @@ void buildsCorrectUrlForDirectory() throws Exception {
             new OyRemote.UrlOy(
                 "https://github.com/objectionary/home/tree/%s/objects/%s",
                 "abcde"
-            ).value("org.eolang.test"),
+            ).value("org.eolang.ss"),
             Matchers.is(
-                new URL("https://github.com/objectionary/home/tree/abcde/objects/org/eolang/test")
+                new URL("https://github.com/objectionary/home/tree/abcde/objects/ss")
             )
         );
     }