Skip to content

During build, download imported ES modules from jsDelivr #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbostock opened this issue Oct 18, 2023 · 4 comments
Closed

During build, download imported ES modules from jsDelivr #20

mbostock opened this issue Oct 18, 2023 · 4 comments
Assignees
@mbostock
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

Rather than loading ES modules from jsDelivr, we could download and self-host them during the build step to remove external dependencies and isolate against new releases.
@mbostock mbostock added the enhancement New feature or request label Oct 18, 2023
@mbostock
Copy link
Member Author

mbostock commented Nov 8, 2023

If we want to bring back import maps (but only for the build case, see #14), we could allow users to configure their import map for self-hosting libraries or choosing a different CDN.

@mbostock
Copy link
Member Author

mbostock commented Nov 8, 2023

Related download-esm.

@mbostock mbostock mentioned this issue Nov 9, 2023
Closed
@mbostock mbostock added this to the Future milestone Nov 13, 2023
This was referenced Dec 4, 2023
Open
Merged
@mbostock mbostock mentioned this issue Dec 6, 2023
Closed
@mbostock mbostock mentioned this issue Jan 16, 2024
Closed
@mbostock
Copy link
Member Author

We could also support caching these files during preview so you don’t have to download them again repeatedly. (And put ’em in docs/.observablehq/cache so you can easily clear the cache if you want to re-fetch the latest versions.)

This was referenced Feb 15, 2024
Closed
Closed
@mbostock mbostock self-assigned this Feb 17, 2024
@mbostock
Copy link
Member Author

mbostock commented Mar 1, 2024

Fixed in #843.

@mbostock mbostock closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

download npm imports; parser & resolver improvements observablehq/framework
1 participant
@mbostock