-
Notifications
You must be signed in to change notification settings - Fork 153
Global config for theme is not getting picked up #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ah! did you check that the page you're looking at doesn't have a theme defined in its front-matter? |
Did you call it I just tested this, and as expected, neither the |
Also note that the default template ---
theme: alt
--- This takes precedence over the theme specified in the config. We should probably remove that here, though — those pages don’t really need a theme override and it’s another opportunity for error. |
The file name was my typo in the original issue. Corrected. As I noted, I verified that other changes to the config properly went through. There is not any theme in the front matter for the pages where I'm looking for the theme. I double-checked that by explicitly adding and removing a theme from one of them. |
did you restart the dev server? Worst case, could you zip the project and send it to me? |
Closing as cannot reproduce. |
I did restart the dev server. I've got a branch going with the edits: pettiross/eia-next |
Found the issue by pairing: the |
Thanks for diagnosing and persisting! |
To repro:
theme: "dark",
to observablehq.config.tstitle
too to verify the config change is picked upExpected:
Theme changes (and project title too) for all otherwise unthemed pages in the project to dark.
Actual:
Other changes are picked up, but not the default theme
The text was updated successfully, but these errors were encountered: