Skip to content

makeCLIResolver should use environment variables for database client secrets, not a config file #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbostock opened this issue Nov 4, 2023 · 1 comment · Fixed by #125
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

mbostock commented Nov 4, 2023

Currently makeCLIResolver looks for a ~/.observablehq JSON configuration file:

https://github.com/observablehq/cli/blob/6dc67f0f5694beea934eb8256f92aa7025e3e2eb/src/resolver.ts#L37-L48

To support building pages with DatabaseClient in GitHub Actions, we’ll want to use environment variables (and repository secrets) instead. I don’t think it’s worth it supporting both — we should remove the code that reads the config file in favor of using process.env.

@mbostock mbostock added the enhancement New feature or request label Nov 4, 2023
@mbostock
Copy link
Member Author

mbostock commented Nov 4, 2023

Possibly the same as #81, although this issue is more opinionated in the recommended solution, and does not discuss secrets (which I expect will be a platform-only feature since there is no way to make them secure without platform support).

@wiltsecarpenter wiltsecarpenter linked a pull request Nov 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants