rename "halo" filters to filter, so they can be reindexed like other filters

Fil · Fil · commit 552b85d0fb16 · 2026-04-16T00:43:26.000+02:00
diff --git a/src/marks/halo.js b/src/marks/halo.js
@@ -6,7 +6,7 @@ const defaultRadius = 2;
 let nextHaloId = 0;
 
 function getHaloId() {
-  return `plot-halo-${++nextHaloId}`;
+  return `plot-filter-${++nextHaloId}`;
 }
 
 export function applyHalo(selection, {halo}) {
diff --git a/test/output/lineHalo.svg b/test/output/lineHalo.svg
@@ -93,7 +93,7 @@
     <text y="0.32em" transform="translate(346.875,258.656)">← 9 quarters into recession</text>
   </g>
   <g aria-label="line" fill="none" stroke-width="1.5" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)">
-    <filter id="plot-halo-1">
+    <filter id="plot-filter-1">
       <feMorphology in="SourceAlpha" result="dilated" operator="dilate" radius="2"></feMorphology>
       <feFlood style="flood-color: var(--plot-background);"></feFlood>
       <feComposite in2="dilated" operator="in"></feComposite>
@@ -102,19 +102,19 @@
         <feMergeNode in="SourceGraphic"></feMergeNode>
       </feMerge>
     </filter>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#9ecae1" d="M60,160.236L91.875,188.472L123.75,190.085L155.625,165.026L187.5,138.709L219.375,148.797L251.25,132.653L283.125,147.51L315,168.745L346.875,162.572L378.75,167.766L410.625,167.225L442.5,149.469L474.375,118.953L506.25,92.11L538.125,64.108L570,37.853"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#6baed6" d="M60,160.236L91.875,172.639L123.75,179L155.625,168.466L187.5,161.63L219.375,156.911L251.25,140.772L283.125,126.145L315,112.811L346.875,98.74L378.75,96.478L410.625,88.606L442.5,82.15L474.375,63.829L506.25,50.733L538.125,32.479L570,24.575"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#3182bd" d="M60,160.236L91.875,151.835L123.75,157.275L155.625,153.52L187.5,142.334L219.375,134.012L251.25,128.55L283.125,126.779L315,119.79L346.875,107.728L378.75,85.308L410.625,69.746L442.5,61.999L474.375,51.478L506.25,38.773L538.125,24.983L570,10"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#08519c" d="M60,160.236L91.875,165.773L123.75,158.034L155.625,165.198L187.5,195.133L219.375,211.036L251.25,213.333L283.125,208.433L315,194.026L346.875,187.261L378.75,174.201L410.625,163.756L442.5,156.727L474.375,159.998L506.25,150.834L538.125,151.36L570,136.232"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="red" d="M60,160.236L91.875,178.032L123.75,305L155.625,206.32L187.5,191.278L219.375,170.634L251.25,148.563L283.125,140.841L315,118.236L346.875,123.065"></path>
     </g>
   </g>
diff --git a/test/output/lineHaloSingle.svg b/test/output/lineHaloSingle.svg
@@ -199,8 +199,8 @@
     <line x1="40" x2="620" y1="24.375" y2="24.375"></line>
     <line x1="40" x2="620" y1="20" y2="20"></line>
   </g>
-  <g aria-label="line" fill="none" stroke="currentColor" stroke-width="1.5" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)" filter="url(#plot-halo-1)">
-    <filter id="plot-halo-1">
+  <g aria-label="line" fill="none" stroke="currentColor" stroke-width="1.5" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)" filter="url(#plot-filter-1)">
+    <filter id="plot-filter-1">
       <feMorphology in="SourceAlpha" result="dilated" operator="dilate" radius="4"></feMorphology>
       <feFlood style="flood-color: var(--plot-background);"></feFlood>
       <feComposite in2="dilated" operator="in"></feComposite>
diff --git a/test/output/lineHaloStyles.svg b/test/output/lineHaloStyles.svg
@@ -68,7 +68,7 @@
     <text transform="translate(580,320)">quarters →</text>
   </g>
   <g aria-label="line" fill="none" stroke-width="1.5" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)">
-    <filter id="plot-halo-1">
+    <filter id="plot-filter-1">
       <feMorphology in="SourceAlpha" result="dilated" operator="dilate" radius="2"></feMorphology>
       <feFlood style="flood-color: lightblue;"></feFlood>
       <feComposite in2="dilated" operator="in"></feComposite>
@@ -77,24 +77,24 @@
         <feMergeNode in="SourceGraphic"></feMergeNode>
       </feMerge>
     </filter>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#9ecae1" d="M40,180.923L73.75,209.228L107.5,210.827L141.25,185.766L175,158.945L208.75,169.287L242.5,152.698L276.25,167.973L310,189.515L343.75,183.287L377.5,188.53L411.25,187.984L445,169.974L478.75,138.465L512.5,110.155L546.25,80.021L580,51.196"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#6baed6" d="M40,180.923L73.75,193.429L107.5,199.798L141.25,189.234L175,182.334L208.75,177.551L242.5,161.066L276.25,145.955L310,132.036L343.75,117.2L377.5,114.8L411.25,106.419L445,99.509L478.75,79.718L512.5,65.407L546.25,45.227L580,36.404"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#3182bd" d="M40,180.923L73.75,172.387L107.5,177.921L141.25,174.103L175,162.67L208.75,154.102L242.5,148.451L276.25,146.613L310,139.338L343.75,126.694L377.5,102.892L411.25,86.139L445,77.726L478.75,66.225L512.5,52.215L546.25,36.86L580,20"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="#08519c" d="M40,180.923L73.75,186.52L107.5,178.691L141.25,185.94L175,215.82L208.75,231.426L242.5,233.666L276.25,228.885L310,214.726L343.75,208.026L377.5,194.995L411.25,184.484L445,177.364L478.75,180.682L512.5,171.367L546.25,171.903L580,156.393"></path>
     </g>
-    <g filter="url(#plot-halo-1)">
+    <g filter="url(#plot-filter-1)">
       <path stroke="red" d="M40,180.923L73.75,198.83L107.5,320L141.25,226.817L175,212.009L208.75,191.415L242.5,169.048L276.25,161.137L310,137.716L343.75,142.752"></path>
     </g>
   </g>
   <g aria-label="line" fill="none" stroke-width="1.5" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)">
-    <filter id="plot-halo-2">
+    <filter id="plot-filter-2">
       <feMorphology in="SourceAlpha" result="dilated" operator="dilate" radius="7"></feMorphology>
       <feFlood style="flood-color: var(--plot-background);"></feFlood>
       <feComposite in2="dilated" operator="in"></feComposite>
@@ -103,24 +103,24 @@
         <feMergeNode in="SourceGraphic"></feMergeNode>
       </feMerge>
     </filter>
-    <g filter="url(#plot-halo-2)">
+    <g filter="url(#plot-filter-2)">
       <path stroke="#9ecae1" d="M40,180.923L73.75,209.228L107.5,210.827L141.25,185.766L175,158.945L208.75,169.287L242.5,152.698L276.25,167.973L310,189.515L343.75,183.287L377.5,188.53L411.25,187.984L445,169.974L478.75,138.465L512.5,110.155L546.25,80.021L580,51.196"></path>
     </g>
-    <g filter="url(#plot-halo-2)">
+    <g filter="url(#plot-filter-2)">
       <path stroke="#6baed6" d="M40,180.923L73.75,193.429L107.5,199.798L141.25,189.234L175,182.334L208.75,177.551L242.5,161.066L276.25,145.955L310,132.036L343.75,117.2L377.5,114.8L411.25,106.419L445,99.509L478.75,79.718L512.5,65.407L546.25,45.227L580,36.404"></path>
     </g>
-    <g filter="url(#plot-halo-2)">
+    <g filter="url(#plot-filter-2)">
       <path stroke="#3182bd" d="M40,180.923L73.75,172.387L107.5,177.921L141.25,174.103L175,162.67L208.75,154.102L242.5,148.451L276.25,146.613L310,139.338L343.75,126.694L377.5,102.892L411.25,86.139L445,77.726L478.75,66.225L512.5,52.215L546.25,36.86L580,20"></path>
     </g>
-    <g filter="url(#plot-halo-2)">
+    <g filter="url(#plot-filter-2)">
       <path stroke="#08519c" d="M40,180.923L73.75,186.52L107.5,178.691L141.25,185.94L175,215.82L208.75,231.426L242.5,233.666L276.25,228.885L310,214.726L343.75,208.026L377.5,194.995L411.25,184.484L445,177.364L478.75,180.682L512.5,171.367L546.25,171.903L580,156.393"></path>
     </g>
-    <g filter="url(#plot-halo-2)">
+    <g filter="url(#plot-filter-2)">
       <path stroke="red" d="M40,180.923L73.75,198.83L107.5,320L141.25,226.817L175,212.009L208.75,191.415L242.5,169.048L276.25,161.137L310,137.716L343.75,142.752"></path>
     </g>
   </g>
   <g aria-label="line" fill="none" stroke-width="1.5" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)">
-    <filter id="plot-halo-3">
+    <filter id="plot-filter-3">
       <feMorphology in="SourceAlpha" result="dilated" operator="dilate" radius="1"></feMorphology>
       <feFlood style="flood-color: pink;"></feFlood>
       <feComposite in2="dilated" operator="in"></feComposite>
@@ -129,19 +129,19 @@
         <feMergeNode in="SourceGraphic"></feMergeNode>
       </feMerge>
     </filter>
-    <g filter="url(#plot-halo-3)">
+    <g filter="url(#plot-filter-3)">
       <path stroke="#9ecae1" d="M40,180.923L73.75,209.228L107.5,210.827L141.25,185.766L175,158.945L208.75,169.287L242.5,152.698L276.25,167.973L310,189.515L343.75,183.287L377.5,188.53L411.25,187.984L445,169.974L478.75,138.465L512.5,110.155L546.25,80.021L580,51.196"></path>
     </g>
-    <g filter="url(#plot-halo-3)">
+    <g filter="url(#plot-filter-3)">
       <path stroke="#6baed6" d="M40,180.923L73.75,193.429L107.5,199.798L141.25,189.234L175,182.334L208.75,177.551L242.5,161.066L276.25,145.955L310,132.036L343.75,117.2L377.5,114.8L411.25,106.419L445,99.509L478.75,79.718L512.5,65.407L546.25,45.227L580,36.404"></path>
     </g>
-    <g filter="url(#plot-halo-3)">
+    <g filter="url(#plot-filter-3)">
       <path stroke="#3182bd" d="M40,180.923L73.75,172.387L107.5,177.921L141.25,174.103L175,162.67L208.75,154.102L242.5,148.451L276.25,146.613L310,139.338L343.75,126.694L377.5,102.892L411.25,86.139L445,77.726L478.75,66.225L512.5,52.215L546.25,36.86L580,20"></path>
     </g>
-    <g filter="url(#plot-halo-3)">
+    <g filter="url(#plot-filter-3)">
       <path stroke="#08519c" d="M40,180.923L73.75,186.52L107.5,178.691L141.25,185.94L175,215.82L208.75,231.426L242.5,233.666L276.25,228.885L310,214.726L343.75,208.026L377.5,194.995L411.25,184.484L445,177.364L478.75,180.682L512.5,171.367L546.25,171.903L580,156.393"></path>
     </g>
-    <g filter="url(#plot-halo-3)">
+    <g filter="url(#plot-filter-3)">
       <path stroke="red" d="M40,180.923L73.75,198.83L107.5,320L141.25,226.817L175,212.009L208.75,191.415L242.5,169.048L276.25,161.137L310,137.716L343.75,142.752"></path>
     </g>
   </g>

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ const defaultRadius = 2;`
`6`	`6`	`let nextHaloId = 0;`
`7`	`7`
`8`	`8`	`function getHaloId() {`
`9`		- return `plot-halo-${++nextHaloId}`;
	`9`	+ return `plot-filter-${++nextHaloId}`;
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`export function applyHalo(selection, {halo}) {`