an nullish legend should not be displayed as tet "undefined" (#746)

Fil · web-flow · commit 8bffb4bdaa34 · 2022-02-09T22:29:51.000+01:00
fixes #745
diff --git a/src/legends.js b/src/legends.js
@@ -76,7 +76,8 @@ export function Legends(scales, options) {
   for (const [key, value] of legendRegistry) {
     const o = options[key];
     if (o && o.legend) {
-      legends.push(value(scales[key], legendOptions(scales[key], o), key => scales[key]));
+      const legend = value(scales[key], legendOptions(scales[key], o), key => scales[key]);
+      if (legend != null) legends.push(legend);
     }
   }
   return legends;

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,8 @@ export function Legends(scales, options) {`
`76`	`76`	`for (const [key, value] of legendRegistry) {`
`77`	`77`	`const o = options[key];`
`78`	`78`	`if (o && o.legend) {`
`79`		`- legends.push(value(scales[key], legendOptions(scales[key], o), key => scales[key]));`
	`79`	`+ const legend = value(scales[key], legendOptions(scales[key], o), key => scales[key]);`
	`80`	`+ if (legend != null) legends.push(legend);`
`80`	`81`	`}`
`81`	`82`	`}`
`82`	`83`	`return legends;`