Skip to content

Commit d3f851e

Browse files
committed
fix waffle stroke (when constant)
1 parent c1aab3b commit d3f851e

9 files changed

+815
-109
lines changed

src/marks/waffle.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ export class WaffleY extends BarY {
3434
}
3535

3636
function waffleRender(y) {
37-
const {unit, gap, rx, ry, round} = this;
3837
return function (index, scales, {href, ...values}, dimensions, context) {
38+
const {unit, gap, rx, ry, round} = this;
3939
const {document} = context;
4040
const Y1 = values.channels[`${y}1`].value;
4141
const Y2 = values.channels[`${y}2`].value;
@@ -103,7 +103,7 @@ function waffleRender(y) {
103103
.join("L")}Z`
104104
)
105105
.attr("fill", (i) => `url(#${patternId}-${i})`)
106-
.attr("stroke", this.stroke == null ? null : (i) => `url(#${patternId}-${i})`)
106+
.attr("stroke", this.stroke == null ? null : "none")
107107
.call(applyChannelStyles, this, {href})
108108
)
109109
.node();

test/output/waffleHref.svg

Lines changed: 77 additions & 77 deletions
Loading

test/output/waffleStroke.svg

Lines changed: 12 additions & 12 deletions
Loading

test/output/waffleStrokeMixed.svg

Lines changed: 6 additions & 6 deletions
Loading

0 commit comments

Comments
 (0)