Skip to content

Ability to exclude tip channels #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
net opened this issue May 25, 2023 · 4 comments
Closed

Ability to exclude tip channels #1638

net opened this issue May 25, 2023 · 4 comments

Comments

@net
Copy link

net commented May 25, 2023

Arguably only the channels in the channels mark option should be rendered in the tip, if the channels option is given.

@mbostock
Copy link
Member

Thanks for the feedback! You can suppress this behavior by specifying a title channel and supplying the content yourself. We don’t distinguish between “extra” channels declared in the channels option vs. normal channels. We may support a way to suppress specific channels using custom formatting (e.g., setting the format to null for a given channel); that is covered by #1612, so I’m going to consolidate this issue into that one.

@net
Copy link
Author

net commented May 25, 2023

Maybe I'm missing something, but I don't see how to supply bold text for channel labels or color squares for color channels with the title option to match the default tip rendering.

@net
Copy link
Author

net commented May 25, 2023

Is the channels mark option just for rendering tips? I can't find any documentation on it outside of the channels tip mark. If so it really seems more intuitive to me that it override the rendered channels rather than append to the rendered channels; in that way it can also be used for full control over the order channels are rendered in the tip.

@Fil
Copy link
Contributor

Fil commented May 25, 2023

Is the channels mark option just for rendering tips?

no

I can't find any documentation on it

There's a mention here: "additional channels can be declared using the mark channels option", but tbf it doesn't say that this is available outside of initializers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants