Skip to content

Commit 18f0ddc

Browse files
authored
Merge pull request #294 from nobrakal/fix293
Use the nonce everywhere
2 parents db6cda8 + 1a64eda commit 18f0ddc

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

src/main/learnocaml_client.ml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -533,19 +533,21 @@ let get_server =
533533
in
534534
Console.input ~default:default_server uri
535535

536+
let get_nonce_and_create_token server nickname secret_candidate =
537+
let secret_candidate = Sha.sha512 secret_candidate in
538+
fetch server (Api.Nonce ())
539+
>>= fun nonce ->
540+
fetch server
541+
(Api.Create_token (Sha.sha512 (nonce ^ secret_candidate), None, nickname))
542+
536543
let init ?(local=false) ?server ?token () =
537544
let path = if local then ConfigFile.local_path else ConfigFile.user_path in
538545
let server = get_server server in
539546
let get_new_token nickname =
540547
Printf.printf "Please provide the secret: ";
541548
match Console.input ~default:None (fun s -> Some s) with
542549
| Some secret_candidate ->
543-
let secret_candidate = Sha.sha512 secret_candidate in
544-
fetch server (Api.Nonce ())
545-
>>= fun nonce ->
546-
fetch
547-
server
548-
(Api.Create_token (Sha.sha512 (nonce ^ secret_candidate), None, nickname))
550+
get_nonce_and_create_token server nickname secret_candidate
549551
| None -> failwith "Please provide a secret"
550552
in
551553
let get_token () =
@@ -855,8 +857,7 @@ module Create_token = struct
855857
| Some c -> c.ConfigFile.server
856858
| None -> get_server server_url
857859
in
858-
fetch server
859-
(Api.Create_token (Sha.sha512 co.secret, None, Some nickname))
860+
get_nonce_and_create_token server (Some nickname) co.secret
860861
>>= fun tok ->
861862
Lwt_io.print (Token.to_string tok ^ "\n")
862863
>|= fun () -> 0

0 commit comments

Comments
 (0)