Skip to content

Commit a1dae04

Browse files
committed
fix(ui): Use proper URL fragments ("#tab=…", not "#tab%3D…")
Related: PR ocsigen/js_of_ocaml#1497 Close #539
1 parent 0b150b9 commit a1dae04

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/utils/js_utils.ml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1201,7 +1201,11 @@ let parse_fragment () =
12011201
let set_fragment args =
12021202
let pairs = List.map (fun (n, v) -> n ^ "=" ^ v) args in
12031203
let fragment = String.concat "&" pairs in
1204-
Url.Current.set_fragment fragment
1204+
(* TODO: Replace with
1205+
{| Url.Current.set_fragment fragment |}
1206+
when https://github.com/ocsigen/js_of_ocaml/pull/1497 is shipped
1207+
within learn-ocaml's dependencies. *)
1208+
Dom_html.window##.location##.hash := Js.bytestring fragment
12051209

12061210
let local_args = ref []
12071211

0 commit comments

Comments
 (0)