Skip to content

Commit c200d97

Browse files
committed
fix(learn-ocaml-client server-version): No need for a cookie file
1 parent 25311fa commit c200d97

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/main/learnocaml_client.ml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -672,14 +672,22 @@ let get_config_option_server ?local ?(save_back=false) ?(allow_static=false) ser
672672
Lwt.return_unit
673673
)
674674
>|= fun () -> (Some c, server_version)
675-
| None -> Lwt.return (None, None)
675+
| None ->
676+
match server_opt with
677+
| Some server ->
678+
let c = ConfigFile.{server; token = None} in
679+
check_server_version ~allow_static server
680+
>>= fun server_version ->
681+
(* Note: could raise an error if save_back=true *)
682+
Lwt.return (Some c, server_version)
683+
| None -> Lwt.return (None, None)
676684

677685
let get_config_server ?local ?(save_back=false) ?(allow_static=false) server_opt =
678686
get_config_option_server ?local ~save_back ~allow_static server_opt
679687
>>= function
680688
| Some c, o -> Lwt.return (c, o)
681689
(* TODO: Make it possible to change this error message (from get_config_o_server) *)
682-
| None, _ -> Lwt.fail_with "No config file found. Please do `learn-ocaml-client init`"
690+
| None, _ -> Lwt.fail_with "No config file found. Please do `learn-ocaml-client init`, or pass a --server=\"URL\" option"
683691

684692
let get_config_o_server ?save_back ?(allow_static=false) o =
685693
let open Args_server in

0 commit comments

Comments
 (0)