Skip to content

Bug: wrong question asked when browsing a complete exercice URL #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erikmd opened this issue May 24, 2022 · 0 comments · Fixed by #489, #486 or ocaml/opam-repository#22877
Closed
Assignees

Comments

@erikmd
Copy link
Member

erikmd commented May 24, 2022

Related project scope(s): exercise UI

Bug description

  • As a user
  • When I am disconnected from a learn-ocaml instance
  • And I paste a complete exercice URL such as https://localhost:8080/exercises/demo/
  • Then I unexpectedly see the question Enter the secret (to create a new account) instead of a more sensible question such as Enter your token.

To reproduce

Steps to reproduce the behavior:

  1. Add a file demo-repository/server_config.json containing:
    {
      "secret": "MDP"
    }
    
  2. Run a learn-ocaml instance, e.g.
    cd ……/learn-ocaml && learn-ocaml build serve --repo=demo-repository
  3. Open a fresh browser instance (e.g., private browsing mode)
  4. Go to https://localhost:8080/exercises/demo/
  5. Then notice the question Enter the secret

Expected behavior

  1. Get the question Enter your token

Optional screenshots

2022-05-24_11-42-19_Screenshot_Secret

Current configuration

  • OS name (and version): N/A
  • Browser name (and version): N/A
  • learn-ocaml --version: 0.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment